golang-gin-realworld-example-app icon indicating copy to clipboard operation
golang-gin-realworld-example-app copied to clipboard

Published 20 hours ago • verified publisher icon gothinkster

update package name and upgrade gin

Open thinkerou opened this issue 6 years ago • 5 comments

thinkerou avatar Aug 30 '18 01:08 thinkerou

Thank you very much! It's a very nice PR, I have left some comments. BTW, I don't know weather travis CI works fine, you could have a try on your own project firstly, that will reduce environment and version changing risk. It will help us test different environment and auto running the tests. https://github.com/gothinkster/golang-gin-realworld-example-app/blob/master/.travis.yml

wangzitian0 avatar Aug 30 '18 04:08 wangzitian0

@wangzitian0 thanks review, I will retry the weekend.

thinkerou avatar Aug 30 '18 05:08 thinkerou

why this is not merged ?

shrhawk-entertainer avatar Mar 25 '19 18:03 shrhawk-entertainer

why not merged?

xdays avatar Jul 11 '19 07:07 xdays

@wangzitian0 who got the write access to this repo? please notify him/her to merge this PR, thanks.

y4code avatar Oct 10 '19 09:10 y4code