angular-realworld-example-app
angular-realworld-example-app copied to clipboard
gothinkster
Feature request: add unit tests
Totally -- PR's would be very appreciated for this as I'm swamped for the next month or so. Anyone out there wanna contribute some sweet unit tests? :)
@ogix @npx any chance ya'll (or anyone else reading this) would be interested?
Ok, I could try but I guess it will take some time because I don't have much experience writing Angular2 unit tests. I will follow the official guide.
Okay -- we might have to do 1-2 rounds of revisions FYI, just to ensure everything is solid & the ang team approves. Can you drop me a note at [email protected] and we'll hammer out details?
@pauldubois777 awesome! we're currently chatting about this in our private slack channel; can you send me an email at [email protected] and I'll invite you?
This thread sort of when cold, any progress on the unit tests? Please let me know if anyone needs more help on this task.
@babilog yeah, this ended up not happening the first time around unf. If you make a PR for unit tests I will absolutely accept them 👍
Hi @umondelo , unfortunately I'm still working on these at the moment. I can probably push a branch later this weekend.
@EricSimons , I'm trying to push my local branch to the repo but currently receiving a permissions issue. Running git push origin mybranchname ... Any thoughts?
$ git push -u origin feature-unit-tests remote: Permission to gothinkster/angular-realworld-example-app.git denied to babilog. fatal: unable to access 'https://github.com/gothinkster/angular-realworld-example-app.git/': The requested URL returned error: 403
@babilog only those added to the collaborators can make changes directly to this repo. You need to create a PR to get the changes pushed here after someone verifies them. To do so upload the repo to your account and create a PR with your new repo to this one.
@babilog ^ what @SandeeshS said! Feel free to make a pull request & I'll review + accept 👍
