angular-realworld-example-app icon indicating copy to clipboard operation
angular-realworld-example-app copied to clipboard

Performance Optimisations + Modernise the application (Angular v11)

Open khaledosman opened this issue 5 years ago • 4 comments

The repo seems to be a bit out of date and isn't using best practices when it comes to performance for angular applications, so this article might be unrealistic for 2019 https://medium.com/free-code-camp/a-realworld-comparison-of-front-end-frameworks-with-benchmarks-2019-update-4be0d3c78075 . This PR aims to change that

  • Upgrade Angular to v9 and upgrade other dependencies to their latest compatible versions
  • Install a service worker with ng add @angular/pwa to make the app a PWA and cache assets.
  • Reduce bundle size by removing unneeded polyfills and drop es5/old browser support, enable differential loading
  • Enable Ivy renderer for smaller bundle size and better performance and update lazy-loading syntax.
  • Update node version in travis.yml to 10.9.0 because the build was breaking after my changes
  • use trackBy in ngFor's for better performance
  • use onPush change detection for better performance
  • Make services tree-shakable
  • use ngx-quicklink preloading strategy instead of preloadAll
  • Lighthouse score improvements, use display=swap for google fonts, add html lang, meta description and alt attribute for imgs
  • Display a fallback/default image for users who do not have one.

khaledosman avatar Apr 09 '19 08:04 khaledosman

v8.0.0 is now officially released, I've updated the dependencies accordingly.

khaledosman avatar May 29 '19 09:05 khaledosman

Any updates?

khaledosman avatar Jun 13 '19 13:06 khaledosman

@khaledosman I will take a look at this PR later today. Thanks for submitting it.

owenmecham avatar Aug 18 '19 16:08 owenmecham

I've updated the pull-request with Angular V9, can someone check this pull request, pretty please?

khaledosman avatar Feb 07 '20 09:02 khaledosman

Deploy Preview for fantastic-marigold-c78593 failed.

Name Link
Latest commit 85d234f96fe11c4e1eab39f2098787397dc99c94
Latest deploy log https://app.netlify.com/sites/fantastic-marigold-c78593/deploys/64a53d7d7c367b00084e3dea

netlify[bot] avatar May 15 '23 07:05 netlify[bot]