gotham
gotham copied to clipboard
Update diesel to 2.0
Codecov Report
Merging #601 (f086e6b) into main (84c7f08) will increase coverage by
0.07%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #601 +/- ##
==========================================
+ Coverage 86.47% 86.55% +0.07%
==========================================
Files 112 112
Lines 5871 5867 -4
==========================================
+ Hits 5077 5078 +1
+ Misses 794 789 -5
Impacted Files | Coverage Δ | |
---|---|---|
examples/diesel/src/models.rs | 33.33% <ø> (ø) |
|
middleware/diesel/src/lib.rs | 80.00% <ø> (+20.90%) |
:arrow_up: |
examples/diesel/src/main.rs | 87.64% <100.00%> (+0.43%) |
:arrow_up: |
middleware/diesel/src/repo.rs | 71.42% <100.00%> (-4.77%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
We'll need to consider semver on this
diesel is a public dependency of the diesel middleware so this is definitely a breaking change
Is there a plan to get this merged? Just finished porting the ORM parts of a project to diesel-2.0 only to find out that gotham_middleware_diesel
isn't compatible with it yet. Would be awesome to get this merged and released soon.
@svenfoo I think my plan was to migrate my server code to diesel 2.0 and test these changes before I merge and release them, but that never happened. Given that the changes seems rather simple and we have tests, it's probably ok to merge this anyways.