gotest.tools icon indicating copy to clipboard operation
gotest.tools copied to clipboard

Remove import aliases

Open elboulangero opened this issue 4 years ago • 2 comments

The import aliases break the so-called so-called “minimal module support” in GOPATH mode. Removing them does not seem to harm.

See https://github.com/gotestyourself/gotest.tools/issues/203

Removing them all with a one-liner:

find -name '*.go' | xargs sed -i 's; // import.*$;;'

Signed-off-by: Arnaud Rebillout [email protected]

elboulangero avatar Jun 11 '20 08:06 elboulangero

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 11 '20 08:06 CLAassistant

Codecov Report

Merging #204 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files          28       28           
  Lines        1964     1964           
=======================================
  Hits         1660     1660           
  Misses        206      206           
  Partials       98       98           
Impacted Files Coverage Δ
assert/assert.go 100.00% <ø> (ø)
assert/cmp/compare.go 94.38% <ø> (ø)
assert/opt/opt.go 80.76% <ø> (ø)
env/env.go 100.00% <ø> (ø)
fs/file.go 93.93% <ø> (ø)
golden/golden.go 90.76% <ø> (ø)
icmd/command.go 85.29% <ø> (ø)
internal/format/format.go 100.00% <ø> (ø)
internal/source/source.go 68.81% <ø> (ø)
poll/poll.go 96.55% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90977a4...b65bb08. Read the comment docs.

codecov[bot] avatar Jun 11 '20 08:06 codecov[bot]