goss icon indicating copy to clipboard operation
goss copied to clipboard

fix: convert line endings of Dockerfile to linux

Open dklimpel opened this issue 1 year ago • 4 comments

Checklist
  • [x] make test-all (UNIX) passes. CI will also test this
  • [ ] unit and/or integration tests are included (if applicable)
  • [ ] documentation is changed or added (if applicable)

Description of change

convert from windows to linux line endings

how to find

find . -not -type d -exec file "{}" ";" | grep CRLF

dklimpel avatar Jul 13 '24 22:07 dklimpel

This has a merge conflict. Once resolved, I'll merge it.

aelsabbahy avatar Jul 29 '24 14:07 aelsabbahy

This has a merge conflict. Once resolved, I'll merge it.

Done

dklimpel avatar Jul 29 '24 14:07 dklimpel

Package: httpd: version:
Expected
    ["2.4.57-11.el9_4"]
to contain elements matching
    ["2.4.57-8.el9"]
the missing elements were
    ["2.4.57-8.el9"]

I'm guessing the image checksum logic isn't working and the images are getting rebuilt, so package versions are drifting on the tests.

aelsabbahy avatar Aug 01 '24 20:08 aelsabbahy

The update of httpd is part of #961

The image checksum logic would work. But this need to upload the image to https://hub.docker.com/u/aelsabbahy and create a checksum file.

The alternative with the ghcr is part of #901

dklimpel avatar Aug 04 '24 10:08 dklimpel