gosling.js icon indicating copy to clipboard operation
gosling.js copied to clipboard

chore: Vite v3.0

Open manzt opened this issue 2 years ago • 3 comments

Migrates Vite to the latest major version (3.0). The biggest change (from our perspective) is that vite now unifies dev/build bundling with esbuild, so the esbuildOptions accomplish the behavior of the custom plugin we had previously.

Vite v3 also changes how workers are loaded, and the bundleWebWorker plugin no longer works. This means that we will need to develop in Chrome (which is the only browser that supports Worker(..., { type: 'module' })). The final build for the editor can be tested in safari and firefox.

manzt avatar Jul 15 '22 18:07 manzt

hmm now the final build doesn't seem to be working...

manzt avatar Jul 15 '22 21:07 manzt

Thanks for this update! Could you elaborate on the issue with the final build?

When I test this locally, I can see that it builds fine.

Screen Shot 2022-07-29 at 14 29 51 Screen Shot 2022-07-29 at 14 32 50

sehilyi avatar Jul 29 '22 18:07 sehilyi

Sorry... should have elaborated so it's not just confusing. The problem is that the final editor build yarn run build-editor is broken. The site throws an error for the BAM example, since the worker code uses Buffer...

manzt avatar Aug 01 '22 14:08 manzt