shippo-php-client icon indicating copy to clipboard operation
shippo-php-client copied to clipboard

PHP 8.1 compatibility & deprecation warnings

Open kingIZZZY opened this issue 2 years ago • 6 comments

Full explanation: https://stackoverflow.com/a/71133750 Shippo_Object implements ArrayAccess: https://www.php.net/manual/en/class.arrayaccess.php

Warnings getting in PHP log:

PHP Deprecated: Return type of Shippo_Object::offsetUnset($k) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in .../vendor/shippo/shippo-php/lib/Shippo/Object.php on line 109

PHP Deprecated: Return type of Shippo_Object::offsetSet($k, $v) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in .../vendor/shippo/shippo-php/lib/Shippo/Object.php on line 99

kingIZZZY avatar Jun 22 '22 21:06 kingIZZZY

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Jun 22 '22 21:06 sonarcloud[bot]

@smkrz or @assislucas Any chance that this could get merged in and tag for a new release?

ajohnson6494 avatar Jan 28 '23 22:01 ajohnson6494

I'd also love to see this merged.

bporcelli avatar May 17 '23 13:05 bporcelli

Not to be annoying, but wanted to hopefully put this back on the radar for @assislucas and @smkrz for review and merging.

pbmang avatar May 17 '23 14:05 pbmang

Hi all, I have surfaced this to the right team at Shippo We will look into validating this change and merging it, thank you for collaborating to our SDK.

assislucas avatar May 17 '23 19:05 assislucas

Thank you @assislucas! I'm sure I speak for everyone when I say that's a real MVP move! Looking forward to seeing this merged, and cleaning up some error messages.

pbmang avatar May 18 '23 00:05 pbmang