shippo-php-client
shippo-php-client copied to clipboard
PHP 8.1 compatibility & deprecation warnings
Full explanation: https://stackoverflow.com/a/71133750 Shippo_Object implements ArrayAccess: https://www.php.net/manual/en/class.arrayaccess.php
Warnings getting in PHP log:
PHP Deprecated: Return type of Shippo_Object::offsetUnset($k) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in .../vendor/shippo/shippo-php/lib/Shippo/Object.php on line 109
PHP Deprecated: Return type of Shippo_Object::offsetSet($k, $v) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in .../vendor/shippo/shippo-php/lib/Shippo/Object.php on line 99
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
@smkrz or @assislucas Any chance that this could get merged in and tag for a new release?
I'd also love to see this merged.
Not to be annoying, but wanted to hopefully put this back on the radar for @assislucas and @smkrz for review and merging.
Hi all, I have surfaced this to the right team at Shippo We will look into validating this change and merging it, thank you for collaborating to our SDK.
Thank you @assislucas! I'm sure I speak for everyone when I say that's a real MVP move! Looking forward to seeing this merged, and cleaning up some error messages.