gorse icon indicating copy to clipboard operation
gorse copied to clipboard

Generate offline recommendation Task loops indefinitely

Open mitar06 opened this issue 10 months ago • 3 comments

Gorse version zhenghaoz/gorse-in-one:latest

Describe the bug I am trying Gorse out with the provided github interactions dataset, everything runs fine on docker but I have noticed that the 'Generate offline recommendation' task keeps restarting indefinitely. I do understand that check_recommend_period and refresh_recommend_period variables dictate if offline recommendations will be recalculated (https://gorse.io/docs/master/concepts/how-it-works.html#worker-offline-recommendation) . Currently these variables are set as:

  • check_recommend_period = "1m"
  • refresh_recommend_period = "24h"

I have confirmed that the Generate offline recommendation Task loops even if I don't add any additional users, items or feedbacks.

To Reproduce

  • Ran docker compose locally
  • successfully imported the demo data into mysql container
  • Restarted all containers
  • Let all tasks complete successfully on the "Tasks" page

Expected behavior Offline recommendations not being calculated over and over again if there weren't any new users, items or feedbacks added to the system .

Additional context Maybe an issue related/similar to this one ( https://github.com/gorse-io/gorse/issues/789 ) I am attaching my docker logs to the issue in case those can help. dockerLogGorse.txt dockerLogRedis.txt dockerLogMySql.txt

Here is the config I am currently using, along with the config.toml file: config.toml.txt docker-compose.yaml.txt

Please let me know if this is the expected behavior or if something needs to be adjusted on my end, my team is looking to use Gorse more on the daily to generate predictions on labeled data, and our main concern is that calculating offline recommendations every minute will use too much of our hardware resources as the underlaying data grows in size.

mitar06 avatar Jan 08 '25 18:01 mitar06

Hi @mitar06, did you find a solution for this? If so, it’d be great if you could share it here — I'm facing the same issue. Thank you


Edit: after editing the configuration file it started to work without any issues.

michalpulpan avatar Feb 04 '25 09:02 michalpulpan

Sounds like this is just a suggestion to improve performance.

Ap3lsin4k avatar Feb 11 '25 20:02 Ap3lsin4k

Sounds like this is just a suggestion to improve performance.

Yeah, it's not a bug, I edited my initial post - I just did not set the config correctly.

michalpulpan avatar Feb 12 '25 11:02 michalpulpan