websocket icon indicating copy to clipboard operation
websocket copied to clipboard

[BUG] Dialer type registered unconditionally into proxy

Open imirkin opened this issue 2 years ago • 0 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

No response

Expected Behavior

No response

Steps To Reproduce

No response

Anything else?

https://github.com/gorilla/websocket/commit/666c197fc9157896b57515c3a3326c3f8c8319fe

This change seems to have switched from the private proxy copy into the project-wide golang.org/x/net/proxy. (It's vendored here, but if one vendors websocket, then it will end up using the sharedly-vendored variant.) Since the registration comes from init() there's no way to prevent it even if the client functionality in question is not needed or desired. Previously this was done into a private "copy" of the proxy logic, which was fine since it was entirely scoped to the websocket client logic. But now it's leaking out.

imirkin avatar Nov 15 '23 23:11 imirkin