websocket icon indicating copy to clipboard operation
websocket copied to clipboard

Published 20 hours ago • verified publisher icon gorilla

Fix Manually passed `Cookie` header overrides `http.CookieJar` cookies

Open masterZSH opened this issue 4 years ago • 5 comments

see issue

masterZSH avatar Jun 08 '20 08:06 masterZSH

move range Jar.Cookies code under range requestHeader

masterZSH avatar Jun 08 '20 08:06 masterZSH

why is this pr not merged? I think it has fixed #597 @elithrar

AllenX2018 avatar Jun 24 '20 03:06 AllenX2018

I have not had time to review. Please be patient - this is not a paid for project and is entirely volunteer run.

(Please do not continually @ me)

elithrar avatar Jun 24 '20 04:06 elithrar

I have not had time to review. Please be patient - this is not a paid for project and is entirely volunteer run.

(Please do not continually @ me)

Sorry~ I don’t know that you are so busy, I just want to work with you to better maintain this community. I’m sorry if you bother!

AllenX2018 avatar Jun 30 '20 06:06 AllenX2018

For some reason, I'm confused by the intention here (or perhaps the bug). Wouldn't the manual application of a cookie overriding the jar be desired? Very rarely do I do something manually and expect the automatic behavior to happen; IE: I always expect one or the other, not both.

To that end, while this may address the issue I question if it is the desired behavior.

IngCr3at1on avatar Sep 08 '20 22:09 IngCr3at1on