mux Allow SkipClean to be evaluated on each route independently.

This provides a solution to #460 . Cleaning is now moved into the route matcher, and is only activated if SkipClean has been set for that specific router (whether explicitly, or by inheritance from a parent route upon creation).

Note that due to the lack of parent knowledge in a Route/Router (which was removed a few months ago), SkipClean() changes only apply to routes that were created after the SkipClean change. Since we have no handle or reference to a Subrouter() once it's been created from the parent router (it's only stored as a matcher interface), we can't make SkipClean() trickle down to the already existing children. New ones will pick it up though. Since this is how other current properties behave, this seemed to be expected behavior.

Mar 21 '19 14:03 gavbaa

Thank you. I’m really behind in review backlog, but a quick ask: also document the “existing children” behavior in the godoc for SkipClean?

Bonus points for adding an example to the README too.

On Thu, Mar 21, 2019 at 7:40 AM George Vilches [email protected] wrote:

This provides a solution to #460 https://github.com/gorilla/mux/issues/460 . Cleaning is now moved into the route matcher, and is only activated if SkipClean has been set for that specific router (whether explicitly, or by inheritance from a parent route upon creation).

Note that due to the lack of parent knowledge in a Route/Router (which was removed a few months ago), SkipClean() changes only apply to routes that were created after the SkipClean change. Since we have no handle or reference to a Subrouter() once it's been created from the parent router (it's only stored as a matcher interface), we can't make SkipClean() trickle down to the already existing children. New ones will pick it up though. Since this is how other current properties behave, this seemed to be expected behavior.

You can view, comment on, or merge this pull request online at:

https://github.com/gorilla/mux/pull/463 Commit Summary

Allow SkipClean to be evaluated on each route independently.

File Changes

M mux.go https://github.com/gorilla/mux/pull/463/files#diff-0 (40)

M mux_test.go https://github.com/gorilla/mux/pull/463/files#diff-1 (34)

M regexp.go https://github.com/gorilla/mux/pull/463/files#diff-2 (17)

M route.go https://github.com/gorilla/mux/pull/463/files#diff-3 (1)

Patch Links:

https://github.com/gorilla/mux/pull/463.patch

https://github.com/gorilla/mux/pull/463.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gorilla/mux/pull/463, or mute the thread https://github.com/notifications/unsubscribe-auth/AABIcHrNMoxNmfrtroTy9JR-Er5jUm8nks5vY5nVgaJpZM4cBlwI .