feeds icon indicating copy to clipboard operation
feeds copied to clipboard

[bug] RSS Item link should be optional

Open enumag opened this issue 3 years ago • 1 comments

According to RSS specification the <link> tag in <item> is optional. Such usage currently fails with this library:

https://github.com/gorilla/feeds/blob/6f6e20dd3953594cd869cf981fb806440685cd21/rss.go#L98

runtime error: invalid memory address or nil pointer dereference

Because of course in that case i.Link is nil so we can't get a Href from it.

enumag avatar Oct 04 '22 14:10 enumag

The CI failure seems to be unrelated.

enumag avatar Oct 04 '22 14:10 enumag

Can we merge this @elithrar, this was pending for the last two years or so. It aligns with the RSS specification.

Related issues https://github.com/gorilla/feeds/issues/97 https://github.com/gorilla/feeds/issues/52

amustaque97 avatar Nov 15 '22 16:11 amustaque97