feeds
feeds copied to clipboard
[bug] RSS Item link should be optional
According to RSS specification the <link> tag in <item> is optional. Such usage currently fails with this library:
https://github.com/gorilla/feeds/blob/6f6e20dd3953594cd869cf981fb806440685cd21/rss.go#L98
runtime error: invalid memory address or nil pointer dereference
Because of course in that case i.Link is nil so we can't get a Href from it.
The CI failure seems to be unrelated.
Can we merge this @elithrar, this was pending for the last two years or so. It aligns with the RSS specification.
Related issues https://github.com/gorilla/feeds/issues/97 https://github.com/gorilla/feeds/issues/52