ferium icon indicating copy to clipboard operation
ferium copied to clipboard

Feedback on why the version was considered incompatible

Open dashkal16 opened this issue 3 years ago • 8 comments

At present, when a curseforge project is not considered compatible, that's all the user is told:

PS D:\Games\PolyMC\instances\BananaCraft_1.18.2\.minecraft\mods> ferium add-curseforge 575698
Adding mod... The project/repository is not compatible

Could the error message be expanded to explain what filter(s) were not met among the files in the project? In the above case, it turned out to be something governed by --dont-check-game-version but that was not at all obvious, especially as the mod in question does declare that it works for 1.18.2

PS D:\Games\PolyMC\instances\BananaCraft_1.18.2\.minecraft\mods> ferium add-curseforge --dont-check-game-version 575698
Adding mod... ✓ (Ars Creo)
Adding required dependency... ✓ Already added
Adding required dependency... ✓ Already added

As of this writing, the newest file for Ars Creo is https://www.curseforge.com/minecraft/mc-mods/ars-creo/files/3776248 Which is flagged for 1.18.2 and Forge

dashkal16 avatar May 14 '22 19:05 dashkal16

smth like Adding mod... The project/repository is not compatible with your game version. add `--dont-check-game-version` if you insist to add it. and for mod loader errors Adding mod... The project/repository is not compatible with your mod loader. add `--dont-check-mod-loader` if you insist to add it.

JustSimplyKyle avatar May 15 '22 02:05 JustSimplyKyle

The problem currently is that the checks are done by a single for loop and if statement (e.g curseforge checking) so this would probably require a completely different method to be used. But yeah this will definitely be a much better user experience

theRookieCoder avatar May 15 '22 04:05 theRookieCoder

And yeah for some reason Ars Creo is not adding even with the proper game version and mod loader

theRookieCoder avatar May 15 '22 04:05 theRookieCoder

I also found that Earthcomputer/clientcommands and Coow/Cows-Odd-Widgets failed to download for 1.18.2 (even with --dont-check-modloader) despite the releases saying they are for 1.18.2.

aschoettler avatar May 19 '22 19:05 aschoettler

Yes because the version is not mentioned in the actual asset name. Sigh we really have to overhaul the GitHub releases checking

theRookieCoder avatar May 20 '22 03:05 theRookieCoder

This hit my radar again so I checked the API myself. The file in question doesn't have version tags when queried through the API. They show fine in the web UI, but not over the API. So that's fun.

I checked all three of https://api.curseforge.com/v1/mods/575698 https://api.curseforge.com/v1/mods/575698/files https://api.curseforge.com/v1/mods/575698/files/3776248

With my own API key and the file's there, but "gameVersions": [] But... image

dashkal16 avatar Jun 02 '22 02:06 dashkal16

I don't know how the CF website works, but it probably uses a different internal API or somehow caches responses? This is an issue with CF, and I've contacted them on the discord CF Dev server and they just didn't reply at all. There's nothing I can do about this :(

I suggest you download the mod and place it in the user folder for now

theRookieCoder avatar Jun 02 '22 05:06 theRookieCoder

Indeed not. Hence the actual request. Being told which flags would have allowed the command to succeed provides a work-around.

dashkal16 avatar Jun 02 '22 05:06 dashkal16