ferium icon indicating copy to clipboard operation
ferium copied to clipboard

Implement filtering for GitHub releases.

Open d-mokliakov opened this issue 2 years ago • 1 comments

Maybe it is not a best idea (because it breaks backward compatibility) but I propose to modify config structure for GitHub mods. From this:

"GitHubRepository": [
    "someGithubUser",
    "someRepoName"
]

To this:

"GitHubRepository": {
    "author": "someGithubUser",
    "repo": "someRepoName",
    "file_mask": ".*-release.jar$" // This parameter is a regular expression.
}

d-mokliakov avatar Apr 30 '22 21:04 d-mokliakov

This would also help downloading this mod in 1.18, since currently ferium downloads the 1.17 version https://github.com/xCollateral/VulkanMod/releases

JustSimplyKyle avatar May 05 '22 10:05 JustSimplyKyle

+1 to this, Ferium currently fails to correctly install 19MisterX98/SeedcrackerX because of the *-api.jar file provided, which I assume Ferium picks because its the top one on the list. Something like:

ferium add 19MisterX98/SeedcrackerX --excludefiles "*-api.jar"

would fix it nicely. (I don't see a way to filter out the right file with an inclusion glob pattern instead of an exclusion one)

jhmaster2000 avatar Nov 12 '22 01:11 jhmaster2000

Moved to #155

Let me know if the GitHub filters I have 'designed' are adequate.

theRookieCoder avatar Mar 24 '23 12:03 theRookieCoder