GDLauncher
GDLauncher copied to clipboard
gorilla-devs
support modrinth
Is your feature request related to a problem? Please describe. As far as I know, there is currently no launcher which can automatically download mods from modrinth
Describe the solution you'd like allow to download modrinth mods alongside curseforge mods
Describe alternatives you've considered I can't think of one
Additional context
I would add a drop down menu to select a modplatform to search mods from, like shown in the screenshot
I was working on that but the api were not stable yet, so i'm gonna wait before finishing it
Il mer 10 mar 2021, 02:25 machinesmith42 [email protected] ha scritto:
how is this?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gorilla-devs/GDLauncher/issues/768#issuecomment-794702765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHO762UFDCBLMPPTBLERA7LTC235XANCNFSM4WQXTSFA .
I was working on that but the api were not stable yet, so i'm gonna wait before finishing it Il mer 10 mar 2021, 02:25 machinesmith42 [email protected] ha scritto: … how is this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#768 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHO762UFDCBLMPPTBLERA7LTC235XANCNFSM4WQXTSFA .
to my knowledge, nothing has happened since. I haven't looked at how stable their api is, but I doubt they changed much (at least their documentation hasn't)
We decided to not add support for modrinth since it goes against the principles that our open-source community has (me not included). Unless they remove ads from their website apparently we won't add support for it. A different story applies to the new closed-source launcher I am working on which will most likely have support for it. If this is confusing to you don't worry, I'll write something about it soon enough.
We decided to not add support for modrinth since it goes against the principles that our open-source community has (me not included). Unless they remove ads from their website apparently we won't add support for it.
The GDLauncher website has ads:
Given that GDLauncher did not previously have a problem the web site for an open source project having ads, what changed if I may ask?
Additionally, GDLauncher currently uses the closed source CurseForge HTTP API to download mods. From what I can tell, both Modrinth code and the code of Ethical Ads (the ad network used by Modrinth) are open source. Supporting Modrinth would only increase the adoption of open source.
A different story applies to the new closed-source launcher I am working on which will most likely have support for it.
I must admit I'm finding it a bit challenging to understand how this resolves the perceived problem of Modrinth not being open source enough by having ads.
I would personally much prefer to continue using an open source launcher, preferably with Modrinth support.
The bisecthosting logo is not advertising but it’s a partnership which is different. This was not my decision, from what I understood our community is just completely against advertisements and against any piece of software that has any. This is not actually limited to ads since also a freemium or open core business model were also rejected even though they are officially encouraged by the sustainable free and open source communities (https://sfosc.org/docs/business-models/loose-open-core/). I myself struggle to understand the hate behind any kind of monetisation on my work yet I respect their decision and I decided to continue with another project of my own which I’ll monetise. Adding support for an open source project with monetisation into this project after all the discussions we had would look controversial at best. I don’t feel that my values and ideas are reflected by this community anymore and that’s why I decided to step down, only review prs once a week and start a parallel closed source project after seeing a clear failure in the open source model from my point of view.
The CurseForge website has ads, though - one popped up at the bottom of the site as soon as I opened it. What makes Modrinth different?
Alright. I won't be working on adding support for modrith, nonetheless, if someone actually wants to create a PR to add support for it I'll be reviewing it. To be fair, if this project needs to be community-driven, this decision should be too.
We decided to not add support for modrinth since it goes against the principles that our open-source community has (me not included). Unless they remove ads from their website apparently we won't add support for it.
Damn, that's a whacky community
They have API documentation: https://github.com/modrinth/labrinth/wiki/API-Documentation They also have a library: https://github.com/modrinth/theseus The API documentation seems pretty simple to use so I don't think the library is necessary.
Just for completeness, I will be reposting here something I wrote on GDLauncher's discord around 3 months ago (I forgot about it for a while).
I was just extremely angry that a project I worked so hard on doesn't want to give anything back for all the work I put into it but I guess that's just life. That is why I decided not to abandon the project but to not actively develop new features, I will still be reviewing the work from contributors.
I have nothing against modrinth and someone from the GDL team will be adding support for it. I am sorry for what I wrote in this issue it doesn't reflect my thoughts nor my ideas, I was just in a bad state of mind.
Don't want to say much but modrinth support will be very handy when the curseforge API sucks
Don't want to say much but modrinth support will be very handy when the curseforge API sucks
Why, what's happening to it?
Don't want to say much but modrinth support will be very handy when the curseforge API sucks
Why, what's happening to it?
Half of mods aren't able to be downloaded by 3rd party launchers, the API is down every other hour, and it's generally terrible.
I'm sorry, the whole thread doesn't make it specially clear what is the current situation of this issue, specially given it's quite old. @Eskaan Would you be willing to accept a PR that adds suport for Modrinth?
Yes absolutely. If you are interested in helping us with that, please reach out on our discord to me or @Ladvace, he's the one who will work on this, I'm sure he could use some help.
How far has progress on Modrinth support gone? Asking as the issues with CF api are causing me not to be aple to download certain 1.19 mods even though they have a 1.19 version on the CF page Check this GDL Discord thread for a more detailed expleanation of the issue: https://discord.com/channels/398091532881756161/984000419971858432
Status...?
Iris has just been removed from CurseForge... now would be THE time to get on with this.
Any updates?? Plenty of mods like Sodium, Mod Menu and tons of general mods that were on CurseForge but aren't anymore and moved to Modrinth are causing compatibility issues and causing people to manually download the mods themselves, which kinda removes the convenience of having a mod launcher in the first place.
This is an open source project, so the general directive for this is DIY. I (sadly) currently don’t have time for this, but I am happy to review any finished pr. You might want to continue on #1322 if you want to work on it.
@Eskaan So you are accepting contributions? I'm asking for clarification because I made the same question in this issue about a year ago, some of you pointed me to Ladvace on Discord but when I reached out to him I didn't get much more than "we're working on it".
This edition of GDLauncher is currently discontinued by our dev team and will soon be replaced by the rewrite of GDL. The old GDL will still be available to the community and this repo will be renamed, but all our development efforts are going towards the rewrite. If you are interested in contributing to the rewrite, we will release the source code of the new repo soon enough, we're currently wrapping up some legal stuff.
If you're instead interested in contributing to this old codebase you're free to do so as well
This edition of GDLauncher is currently discontinued by our dev team
Yeah, as he said. I am the only dev currently (working on/)maintaining this, but I don't have much time to develop stuff myself. I am always happy to make a review and I do have the rights to merge and make a new release.
this divide unforntunaly is going to possibly grow more; I dont know much but from what little I know Curseforge did something that pissed off some people
This edition of GDLauncher is currently discontinued by our dev team and will soon be replaced by the rewrite of GDL. The old GDL will still be available to the community and this repo will be renamed, but all our development efforts are going towards the rewrite. If you are interested in contributing to the rewrite, we will release the source code of the new repo soon enough, we're currently wrapping up some legal stuff.
If you're instead interested in contributing to this old codebase you're free to do so as well
As of now is modrinth support planned/in-development for the rewrite? I don't mean to pester on it but as others have mentioned more and more mods are starting to switch to modrinth. I myself have been building out a new pack over the past few days and, whereas in the past modrinth being missing was a bit of an annoyance, I've actually found several mods that just aren't on curseforge at all . It seems like the switch is happening mostly for fabric mods, but a good few forge ones are starting to as well, and Modrinth being missing is starting to cause pretty large problems as more and more mods begin to migrate.
If you don't know I get it, but it's a pretty big feature that has been requested for a while now and it's abscence is starting to rear its head more and more as time goes on, so it seems like something that should be getting at least some love in a rewrite. (although if a rewrite is already in progress it would make sense to not work on ading it to GDLauncher as-is since that's a lot of work for code that's going to most likely become obsolete quite soon, but in the rewrite itself it seems like it should probably take some focus.)
Modrinth is definitely getting supported in the rewrite, it's currently planned for phase2, which will happen over the next couple of months. We are currently starting an internal initial test for an MVP version of the launcher, once all the basics are ready we will open a public alpha and start working on adding modrinth support