Non Curse mods incorrectly detected as Curse mods on 1.12.2

[nat212]

Describe the bug When adding a non curseforge mod (e.g OptiFine, Nutrition) to an instance, either via drag and drop to the mod screen, or copying to the mods folder, the mod shows up in the mod list with a curse icon. Possibly related, is that when exporting the instance to a ZIP file, the overrides directory does not include the non curse mod.

To Reproduce Steps to reproduce the behavior:

1. Create a new instance with Forge
2. Right click instance, click manage
3. Select mods from the left hand menu
4. Drag and drop a non curse mod .jar (e.g OptiFine)
5. See a curse icon next to the mod

Expected behavior It should be detected as a non curse mod

Possible solutions I'm not sure what the underlying issue is, so I cannot provide any possible solutions.

Screenshots

Operating System:

• OS: MX Linux (Debian based)
• Version 19

Additional context I have tested this with the latest version of Forge for 1.16.4, and that seems to work correctly, however, with three version of Forge for 1.12.2 (14.23.5.2841, 14.23.5.2855, and 14.23.4.2767), this issue occurs.

[nat212]

Note: most likely related to https://github.com/gorilla-devs/GDLauncher/issues/668, as clicking a non curse mod that has been incorrectly picked up as one crashes the launcher (presumably due to invalid metadata)

[Eskaan]

This is a duplicate of #668. Anyways, I will leave it opened because its an other error resulting from it