Vanilla Snapshot 22w42a will not launch

[troywweber7]

• [X] I searched the issue tracker for other issues covering my case
• [X] This is a Launcher issue. (Usually if you can reproduce it with a fresh instance)

Describe the bug Cannot launch 22w42a.

To Reproduce Steps to reproduce the behavior:

1. Open GDLauncher 1.1.29
2. Create a new instance for Vanilla Snapshot 22w42a and wait for it to download game files
3. Try to launch
4. Launcher is stuck loading and never launches instance

Expected behavior Launches 22w42a.

Possible solutions I could download the vanilla launcher and launch through there, I suppose.

Screenshots It get's stuck with the following loading screen while all my other instances close GDLauncher and within 1-3 seconds are a minecraft instance.

Operating System:

• OS: Ubuntu 20.04
• Launcher Version: 1.1.29
• Java Version: 8/17
• Minecraft Version: 22w42a
• Mod Loader: NA, Vanilla

Additional context No additional context. Thanks for your help!

[Eskaan]

Could you post your console output after trying to launch an instance, please? Preferably as screenshot as otherwise stacktraces and co. will be copied.

[megabyte6]

Here's the console before trying to open the instance:

Here is it after:

This is the console after I try to kill the instance:

---

I hope this helps!

[troywweber7]

I haven't had time to fork this and try to resolve it and create a PR myself, but it looks like this line just needs to take into account the possibility of minecraftArguments being undefined as all of my other instances are launching just fine.

[megabyte6]

Yeah, it seems to be that line. I don't think that undefined should've even been an option though.

As for killing the instance after it fails to start, the error is just an invalid pid. Which makes sense since the instance never started to begin with.

[troywweber7]

I'm not super familiar with the typical contents of mcJson, but I believe you. That said, it seems to be the case that even if it shouldn't be undefined, it somehow is. If we expect an empty string one could just nullish-coelesce to an empty string, e.g. (mcJson.minecraftArguments ?? '').split(' ').

EDIT: added example of nullish-coelescing

[troywweber7]

@Eskaan please note that @megabyte6's are the exact results I receive as well. Further, this is is NOT supplicated by the 22w43a issue. I advise to keep these separate until you can accurately confirm they are duplicate.

[Eskaan]

I just checked, you are right. They seem to have changed something with log4j in 22w43 that changes the download,