GDLauncher
GDLauncher copied to clipboard
gorilla-devs
Failed update should not delete instance
Describe the bug When updating a pack, if the update fails it deletes the instance.
Expected behavior / Possible solutions A better solution might be to mark the instance as corrupted so that the user has a last chance to backup the world files. and try to perform the update again or recreate the instance.
Operating System:
- OS: Windows
- Version: 10
With the CurseForge API issue, this is even more critical. I just lost my testing world and a pile of screenshots of an in-progress build because one of the mods in the pack opted out of the new API.
I think it is fixed - https://github.com/gorilla-devs/GDLauncher/blob/master/src/common/modals/InstanceDownloadFailed.js#L31 Just waiting for confirmation from @Ladvace
let's see if somebody gets the same error, honestly It should be fixed but I'm not sure.
Looks like I just had the same issue : I updated Vault Hunter Modpack and GDLauncher as well. When I tried to launch the modpack, I had an error. I "repaired" the modpack then launchedit again. No more mod nore world in the modepack (not even in the folders). Can I do something to recover it ?
Repairing an instance should not delete any saves whatsoever. It just tries to fix the gamefiles (which are in an entirely different folder btw). This issue only affects pressing cancel after some error (it seems like it was fixed in a newer version tho).
I just had this happen to me, wiped 3 days worth of progress on Astropolis.
Got the above error, retired twice, still got the same error, canceled download waited 5 minutes but seemed like it was hung so I closed GDLauncher. When I opened back up I tried to update again and it wasn't finding any versions to update. I opened the instance folder and to my horror this was all that was in there
I'm not sure why, with no option to create a new profile when updating, it's completely wiping the instance.
Hello I also lost my world, I had to close the game via the task manager because it had crashed. When I restarted it I had an error coming from a corrupted config file so I used the "Repair" option of GD LAUNCHER but it crashed (see picture below) and it destroyed all the game files because when I click on "cancel download" nothing happens for hours!
I don't say thank you for the tens of hours lost :(
The button stays gray like this forever
I just had this happen to me. Lost a weeks worth of progress in Roguelike Adventures and Dungeons 2, which is beyond frustrating! Why on earth would it just wipe out an instance when a download is cancelled?! Surely it should at least move it to a different place temporarily or something...
I was trying to update the modpack but I was stuck on the Cloudflare page when trying to download opted-out mods, so I cancelled the download after a while and it just hung, so closed GDL and found out the instance had been wiped when trying to launch it.
Just had this happen to me - this is a serious enough bug that I really can't recommend GDLauncher to people any more. There is no reason a modpack update should be touching configuration data or worlds.
I am disgusted I just lost my save this way. Is there really no way to get it back?
I am disgusted I just lost my save this way. Is there really no way to get it back?
My backup software (CrashPlan) had a copy of my instance and save. Check your backup software?
(Disclaimer: I am an engineer at CrashPlan.)
I'm on a Mac I don't need a backup I never have a problem. Only my documents and photos are backed up in the cloud.
What an idea to delete a backup like that ... it was a game I had with my daughter for a long time. I just wanted to upgrade to 1.19.3 forge, I got an error and then I lost everything.
We're not going to play Minecraft again.
I’m so sorry if you lost any of your saves, I am not currently available to do any bug fix, but I’ll make sure to post an announcement in the launcher asap to let people know about this issue. You could try to recover your saves using a recovery tool like recuva. Please feel free to contact me in private on discord if you need help trying to recover the data.
I'd recommend everyone affected by this try out Prism Launcher for an alternative with a slightly less intuitive UI that won't completely trash your data - the feature set is mostly identical, with the exception being you have to install Java 17 yourself in most cases.
Just happened with me as well on my several hundred hour DJ2 world, is there really no way to get those files back at all?
I'm sorry @SteveMcKoy. I don't know exactly the cause or repercussions of this bug. You can contact me on discord (@Davide#1234) and we can try to recover it.
As for the other people, I published a temporary announcement on the launcher so that other people don't incur into this problem
