[v4] Setting `enableContentPanningGesture` to `false` breaks `BottomSheetScrollView`

[simon-abbott]

Bug

Setting enableContentPanningGesture to false breaks the scroll interaction with BottomSheetScrollView. Namely, while the user's finger is still down they can move it all they want and the content does not scroll at all, but when they release their finger the momentum is applied.

Environment info

Library	Version
@gorhom/bottom-sheet	4.1.4
react-native	0.64.2
react-native-reanimated	2.2.3
react-native-gesture-handler	1.10.3

Steps To Reproduce

1. Make a BottomSheet with enableContentPanningGesture={false}
2. Put a BottomSheetScrollView in it with enough contents to make it scroll
3. Expand the sheet and try to scroll the contents

Describe what you expected to happen:

Setting enableContentPanningGesture to false should disable the ability to collapse the sheet by panning, but it should not affect scrolling the contents.

Reproducible sample code

https://snack.expo.dev/@simon.abbott/bottom-sheet-scroll

[zakthedev]

I'm having the same issue here.

[dentep]

Same problem.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[simon-abbott]

Not fixed, don't close.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[simon-abbott]

Bump.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[simon-abbott]

Bump!

[DominykasDriu]

@simon-abbott hey, I had a similar issue with a date picker inside modal. I solved the issue by using BottomSheetView and inside it using ScrollView from react-native-gesture-handler

import { ScrollView } from 'react-native-gesture-handler';

<BottomSheetView> <ScrollView> {contents} </ScrollView> </BottomSheetView>

[simon-abbott]

Using a different ScrollView does work, but the problem is that I need to be able to set enableContentPanningGesture dynamically, and when it's enabled I need to use a BottomSheetScrollView so the drag-to-close works as expected. I can swap between the two dynamically based on whether or not the sheet should be enabled, but swapping out the components loses the scroll amount (snaps back to top), and I couldn't find a clean (and performant) way to preserve the scroll offset through that transition.

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[simon-abbott]

Not fixed, don't close!

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[simon-abbott]

bump

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[simon-abbott]

bumpity bump

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[simon-abbott]

bump

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[simon-abbott]

Commenting to keep open

[lucarducci]

same problem here too

[cuanclifford]

please fix this

[AliMSbaee]

Same!

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[AliMSbaee]

Pump

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[simon-abbott]

Still a problem, do not close.

[keithluchtel]

@simon-abbott I ran into as similar issue and ended up doing:

      enablePanDownToClose={false}
      enableOverDrag={false}>

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[simon-abbott]

Not fixed yet!

[Zakyyy]

any solution