react-native-bottom-sheet icon indicating copy to clipboard operation
react-native-bottom-sheet copied to clipboard

How to increase snap strength/threshold

Open jhleao opened this issue 3 years ago • 16 comments

Ask your Question

Is there a way to increase how much the user has to drag in order to change snap points, making the sheet less sensitive to small gestures? If so, how can I achieve this?

Note: I've found a similar question on this topic that hasn't been answered

jhleao avatar Aug 06 '21 02:08 jhleao

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Oct 05 '21 09:10 github-actions[bot]

I'm running into what sounds like a similar issue. For me, the velocity needs to be configurable to determine which snap point to snap to. I have enablePanDownToClose and it's way too easy to accidentally dismiss the modal when I actually want to go to snap point 0.

zachgibson avatar Oct 08 '21 21:10 zachgibson

i have created a PR to redash to allow passing threshold to control the snap point implementation, lets hope this get merged, if not, i will move this implementation to the library 👍

gorhom avatar Oct 17 '21 14:10 gorhom

Awesome!

zachgibson avatar Oct 17 '21 15:10 zachgibson

@gorhom really would love this feature as well.

I see that you closed your PR to redash on Nov 3rd. Would it be possible to get a status update?

jspizziri avatar Dec 07 '21 22:12 jspizziri

any updates?

7dp avatar Feb 15 '22 07:02 7dp

@gorhom do you think we will still be able to get this in your lib?

zachgibson avatar Mar 23 '22 21:03 zachgibson

cc @vonovak @kickbk

jspizziri avatar Mar 29 '22 13:03 jspizziri

@vonovak , you're both listed as contributors to this lib in the README, so I tagged you as I thought you might have some insights into this particular issue. But if not no big deal.

jspizziri avatar Mar 29 '22 13:03 jspizziri

hello @jspizziri, people there are listed because they have contributed. Please note that contributor != maintainer, and even being a maintainer does not necessarily imply being responsive as said here.

One of the beauties of open source is that it is open. When comment is added, people can see it. When a PR is opened, people can see it. When code is added, people can see it. When an update happens, it's not hidden.

If you feel something is stuck, I suggest you get involved and contribute what you need yourself.

Just my 2 cents, thank you and have a nice day 🙂.

vonovak avatar Mar 29 '22 14:03 vonovak

@vonovak , sorry for putting you off. I'm fully aware of how OSS works, and I've been a contributor on many projects. I suppose the README is just confusing, as If I wanted to see general contributors I would just go here. Having something in the README typically signals more than just a casual contributor. There's no other canonical source of who has the ability to make things happen.

Also, I'm more than happy to contribute to the project. However, without someone who has the power to make decisions and is willing to work with potential contributors to review MRs and set architecture, any effort is pointless. There's no point in an MR that will never get merged or have feedback. This is a perfect example of something being "stuck" that requires insight from someone who has authority on the project to set the proper direction before someone works on it. People who want to contribute need to be able to make good decisions around forking a project or pushing a project forward. I hate forking unless it is explicitly stated that the project will no longer be maintained by its original authors.

If @gorhom is truly the only maintainer I apologize for misinterpreting the documentation in what I consider to be a fairly statistically likely manner. Please feel no further need to respond. For your convenience, I created an MR to remove you from the README so that people don't get understandably confused in the future.

jspizziri avatar Mar 29 '22 14:03 jspizziri

has there been any development for this feature? I'm currently running into the same issue that op explained.

igaboo avatar Feb 06 '23 22:02 igaboo

Any updates on this one? This is the only missing piece from this library.

saransh-malik avatar May 27 '23 06:05 saransh-malik

Any updates ?

BubbleTrouble14 avatar Aug 29 '23 13:08 BubbleTrouble14

working hard on this?

jeffinhk avatar Jan 11 '24 07:01 jeffinhk