react-native-bottom-sheet icon indicating copy to clipboard operation
react-native-bottom-sheet copied to clipboard

feat: add stack behavior replace-and-dismiss

Open janodetzel opened this issue 1 year ago • 3 comments

I added a new stack behavior type which dismisses the previous modal instead of minimizing it.

Please provide enough information so that others can review your pull request:

Motivation

This new stack behaviour type is important to enable users to dismiss the previous modal when a different modal is opened.

janodetzel avatar Jul 26 '24 23:07 janodetzel

@gorhom can you have a look at this new stack behaviour type? Would triggering dismiss() instead of minimize() cause any problems?

janodetzel avatar Aug 06 '24 09:08 janodetzel

hi @janodetzel thanks for submitting this PR, i think the naming replace does not represent its functionality , might worth renaming it to stack or switch. and replace would be the present and dismiss old sheet

gorhom avatar Aug 17 '24 17:08 gorhom

@gorhom , Greetings! This may not be entirely on topic, but I would like to ask. Is there a possibility to add a current example of using BottomSheet with @react-navigation/native? The link to the example in the description is no longer valid: https://github.com/gorhom/react-native-bottom-sheet/blob/master/example/bare/src/screens/integrations/NavigatorExample.tsx

EvgenMart avatar Sep 27 '24 09:09 EvgenMart

@janodetzel thanks for submitting this PR, i have already introduce this feature on v5 https://gorhom.dev/react-native-bottom-sheet/modal/props#stackbehavior

gorhom avatar Oct 26 '24 07:10 gorhom