react-native-bottom-sheet icon indicating copy to clipboard operation
react-native-bottom-sheet copied to clipboard

New public method getState. Easier to open and close sheet with one button

Open BogdanGorelkin opened this issue 1 year ago • 2 comments

In some cases it would be useful to get the BottomSheet state. Especially when the same button should open and close the sheet. It would be great if you'll add this feature to the new version.

P.S: The same changes made from the HEAD v5.0.0-alpha.10 can be found in this brunch.

PP.S: I temporarily commented out the ignoring of the /lib folder in the .gitignore file. Without this change while installing package by command: npm install BogdanGorelkin/react-native-bottom-sheet#public_method_getState-v5.0.0-alpha.10 types are not being compiled

BogdanGorelkin avatar Jun 17 '24 21:06 BogdanGorelkin

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jul 19 '24 09:07 github-actions[bot]

This pull request is still actual

BogdanGorelkin avatar Jul 19 '24 12:07 BogdanGorelkin

Hi @BogdanGorelkin,

  1. this PR has 516 files change, which i won't accept, i hope you understand the rational here.
  2. providing animated index to the bottom sheet will always update you with the bottom sheet position index, which will tells you if the bottom sheet is open or close

gorhom avatar Aug 31 '24 16:08 gorhom