react-native-bottom-sheet icon indicating copy to clipboard operation
react-native-bottom-sheet copied to clipboard

Published 20 hours ago • verified publisher icon gorhom

chore: introduce bare-fabric example

Open AndreiCalazans opened this issue 1 year ago • 2 comments

Motivation

This includes a fabric enabled example that can be used to verify the library is properly working with Fabric.

The example app doesn't fully work with Fabric due to:

  1. The usage of findNodeHandle
  2. react-navigation's Card component using setNativeProps
  3. Reanimated's V3 RC crashing when using useReanimatedRef.

I have a follow up PR where I remove findNodeHandle usage from this library to make it fully compatible with Fabric.

cc @gorhom

AndreiCalazans avatar Sep 13 '22 20:09 AndreiCalazans

Thanks @AndreiCalazans for submitting this PR.

I don't think we need to have an example for Fabric, or at least a separate example. I will look into extracting the example into another repo in the feature.

gorhom avatar Sep 17 '22 16:09 gorhom

Thanks @AndreiCalazans for submitting this PR.

I don't think we need to have an example for Fabric, or at least a separate example. I will look into extracting the example into another repo in the feature.

Sounds good. It made it easier for me to test both in parallel. The example apps are nicely setup, nice job by the way.

AndreiCalazans avatar Sep 17 '22 17:09 AndreiCalazans

Is there any plan to review and merge this PR? I think this PR gets bottom-sheet compliant with reanimated v3.

only1chi avatar Oct 03 '22 15:10 only1chi

Reanimated's V3 RC crashing when using useReanimatedRef.

Hello! Could you please submit an issue in Reanimated repo so we can address this problem as soon as possible? Thanks in advance!

tomekzaw avatar Oct 03 '22 20:10 tomekzaw