uMatrix icon indicating copy to clipboard operation
uMatrix copied to clipboard

Support RTL languages

Open gorhill opened this issue 11 years ago • 10 comments

Just like with uBlock, I need to go through all HTML codes to be RTL language-friendly

gorhill avatar Nov 01 '14 14:11 gorhill

This is a blessed move on my part (I am the Hebrew translator on Crowdin), and would be glad to help.

Mikey1993 avatar Nov 01 '14 15:11 Mikey1993

I will use a different approach than with uBlock though, as per @Deathamns' input: using @@bidi_ makes the code non-portable. It can be avoided with a mix of simple CSS/JS.

gorhill avatar Nov 01 '14 15:11 gorhill

Sure thing, I agree.

Mikey1993 avatar Nov 01 '14 16:11 Mikey1993

So I am going to try and fix this today. There are things I am not sure about how it should render for RTL languages, like the matrix:

a

Should the top toolbar be exactly reverse-ordered (i.e. scope selector to the right, etc.), or should I keep the exact same order?

Also, what about the matrix columns, exact same or exact reverse?

gorhill avatar Nov 02 '14 16:11 gorhill

The top toolbar should be reverse-ordered, e.g. the "mozilla.org" drop down list on the most right, then the power button icon, then the lock icon and so on..

While the matrix columns should be as shown in your image. Although I see that some of the titles are cut out, is it something you are gonna address?

Thanks for your work!

Mikey1993 avatar Nov 02 '14 19:11 Mikey1993

Re. "middle". This is what I have on my side when using "he" locale:

a

gorhill avatar Nov 05 '14 22:11 gorhill

Yes, I was silly and didn't update uMatrix to the latest version where you've applied the second patch to this issue - it looks like in your image.

BTW, I am worried about the cut off of some of the headers on the matrix, I have no shorter names or abbreviations for them... Any thoughts about that?

Mikey1993 avatar Nov 05 '14 22:11 Mikey1993

Actually... I think that the font that English uses is narrower than the one that is used by Hebrew. Can we sort this out and ultimately fix the cut off?

Mikey1993 avatar Nov 05 '14 22:11 Mikey1993

Difficult to solve. There is a limit on how wide a popup can be. When using the setting "Large font", the popup is very close to the limit, and we have to be sure we don't beyond this limit, or the matrix will be all broken, i.e. no longer a matrix visually.

gorhill avatar Nov 06 '14 00:11 gorhill

I will experiment with CSS transform tricks when I have time, but I won't hold from "shipping" for now.

gorhill avatar Nov 06 '14 13:11 gorhill