uBlock-for-firefox-legacy icon indicating copy to clipboard operation
uBlock-for-firefox-legacy copied to clipboard

Add support for entity-matching in `domain=` filter option

Open THEtomaso opened this issue 4 years ago • 4 comments

When these type of rules starts to appear, it's important that uBO Legacy supports them!: https://github.com/gorhill/uBlock/commit/3c67d2b89f8ac6d680e74af3e11b916889f7/

THEtomaso avatar Jun 16 '20 18:06 THEtomaso

@hawkeye116477:

Your thoughts on this.. Is it something that you would consider looking into?

uBlock filters already contains some rules now, which depends on this feature. When their big filter revision process takes place, uBO Legacy will be severely crippled, unless it supports those type of syntaxes!

--

EDIT: I rewrote the current incompatible rules for uBO's Legacy filter: https://github.com/uBlockOrigin/uAssets/commit/db8e32588e4605d8a835cef0cc696c56f78e96fb/ ..but of course, this isn't a long-term solution.

THEtomaso avatar Aug 22 '20 12:08 THEtomaso

@THEtomaso I won't promise nothing, but maybe. You don't need to shout, I hear you...

hawkeye116477 avatar Aug 27 '20 08:08 hawkeye116477

"Shouting" means writing everything in capital letters. I never do that. :)

THEtomaso avatar Aug 27 '20 09:08 THEtomaso

I just rewrote more domain=.* entries for uBO's Legacy filter. At the moment, I think everything is covered, but this syntax is commonly used now, so I don't know for how long I will be able to keep up.

If anyone wants to help out, here's how: 1 - Search up the domain=.* entries in uBO Filters, using this parameter: /domain=.*\*/ 2 - Make sure that the rules haven't already been rewritten for uBO's Legacy filter. 3 - Look up the .* domains (excluding .*) at https://instantdomainsearch.com/domain/extensions/ 4 - Rewrite the rules, covering all of the taken TLDs (marked in red). 5 - Post the rewritten rules here: https://github.com/uBlockOrigin/uAssets/commit/db8e32588e4605d8a835cef0cc696c56f78e96fb/

THEtomaso avatar Sep 13 '20 17:09 THEtomaso