httpswitchboard icon indicating copy to clipboard operation
httpswitchboard copied to clipboard

Feature request: Option(s) to hide blocked elements

Open Ken-g6 opened this issue 11 years ago • 10 comments
trafficstars

One thing I notice about httpswitchboard that's very different from AdBlock: Blocked elements are not fully hidden. I see broken images and areas where iframes would be. Sometimes I want to see these things, but most of the time I don't. Could there be option(s) to hide these with CSS display:none, please?

I see an option to change the color of removed iframes, but that doesn't quite cover it.

Ken-g6 avatar May 24 '14 19:05 Ken-g6

In case it isn't clear, I don't want HTTPSB to be like Adblock.

gorhill avatar May 24 '14 20:05 gorhill

Well, in case Ken-g6 wasnt clear, this is not very effective: image

That's a video stream with a blocked ad over it. Even if I set "Blocked frames color" to transparent, the box that says the domain of the blocked frame still appears.

EDIT: Ok, (I think) I now see what you meant. Anyways this is a feature request so it's your call. In my opinion it's a good idea to have that option (it could be off by default).

RuiAlias avatar May 24 '14 21:05 RuiAlias

Can I have a URL to that page for testing purpose?

gorhill avatar May 24 '14 21:05 gorhill

Sure, www.ptcanal.com/tvi.php.

RuiAlias avatar May 24 '14 21:05 RuiAlias

Well, since @gorhill shot me down I've been trying to fix this with user styles/scripts. My efforts with iframes were less than successful, at least so far, but I got broken images to disappear. (All broken images.)

https://gist.github.com/Ken-g6/8d467443b9f62c631bf7

Edit: Seems to have had some effect on other images too, though. Back to the drawing board.

Edit2: And I think I have a better approach there now.

Ken-g6 avatar May 24 '14 21:05 Ken-g6

Ok I see the white box, which defeats the purpose of allowing transparent frame. Will look into a fix.

gorhill avatar May 24 '14 21:05 gorhill

Meanwhile you may want to try this ubiquitous rule in the Your block rules text area: ptcanal.com###above

Looks like this should be proposed for inclusion in ABP EasyList.

gorhill avatar May 24 '14 22:05 gorhill

@ruimams I move the transparency problem to issue #299, as it is a separate issue from the feature requested here.

gorhill avatar May 24 '14 23:05 gorhill

And I think I have a better approach there now.

For HTTPSB something will be needed though, since an error not caused by HTTPSB could cause an image to not be loaded, and in such case I doubt hiding the image is a good thing.

I will thin about the best way to implement this properly in HTTPSB, which certainly involves communication between the injected content script and the background page.

gorhill avatar May 25 '14 00:05 gorhill

@gorhill Great, thanks. I thought it was intentional so you could "See ALL the remote connections, failed or attempted(...)" (quoting README.md) and that was why I was rooting for the hiding of blocked elements.

RuiAlias avatar May 25 '14 11:05 RuiAlias