httpswitchboard icon indicating copy to clipboard operation
httpswitchboard copied to clipboard

Add information when hovering a blocked item in the matrix

Open srouquette opened this issue 10 years ago • 6 comments

It would be useful to be able to see what is blocked (or unblocked) when you hover an item in the matrix, for example the name of the cookie or the path to a js script file, it may give more informations about which decision we should make when allowing an item.

srouquette avatar May 16 '14 09:05 srouquette

Something which must be very carefully thought out beforehand. Many issues come to mind:

  • It's not uncommon for some cells to get high count of items (ex. 28 scripts here)
  • This means keeping around information which is not currently available, i.e. the full URL of all requests on a page (thus increasing memory footprint... I don't want to evolve toward a bloated extension CPU and memory wise after putting so much dev time clamping down on cpu/mem abuse)
  • The hovering over matrix cells is already used to interact with the cell, and having a popup show up for any cell the mouse passes over would be mightily annoying. (I did implement a prototype once for this kind of feature: I trashed it, I found it was more annoying than useful -- we have to think about how this is useful for the majority of users).

gorhill avatar May 16 '14 12:05 gorhill

ok, I understand. Feel free to close this request then.

As a new user, it can be hard to understand which part should be allowed or not. for example, the frame for gmail. Even by allowing most things for gmail, it still didn't work because the "frame" was blacklisted globally. My thought process was "well, it didn't work, let's allow the frame to see if it works now...". I don't really know why I had to allow it, and I don't really know if I can blacklist other parts without breaking it.

I saw later I could check the console in the settings and see what's blocked.

srouquette avatar May 16 '14 12:05 srouquette

I saw later I could check the console in the settings and see what's blocked.

Yes, and another contributor added keyboard support to make it less tedious to reach the Statistics tab, you can assign a keyboard shortcut to open that tab -- from the chromium Extensions page.

I will leave the issue opened, as I know somebody else asked for this recently (I have to find the issue number), so others may also want to pitch in, but as said, all the consequences of such a feature must be thoroughly thought out.

gorhill avatar May 16 '14 12:05 gorhill

I see giving the information when hovered over the matrix might be problem in the case of blocked count on the cell is more than 1. I think this can be better mitigated by bringing blocked requests from statistics page to developer toolbar. There is a ticket for this already..https://github.com/gorhill/httpswitchboard/issues/144

I think with this approach, i like to see "remember last number of requests" to be removed. As i feel it is redundant if we show the blocked/allowed requests per tab.

harshanvn avatar May 16 '14 14:05 harshanvn

indeed, it's easily accessible with ctrl+shift+i

srouquette avatar May 16 '14 14:05 srouquette

I messed around with the request log by adding 2 new filters, ( Blacklisted & ABP ), to narrow down the requests even more. I wanted to be able to hide the blacklisted requests just like you can in the matrix.

This is what it looks like when all blocked requests are shown. httpsbblacklistabpchecked

This is what it looks like when you uncheck Blacklisted and ABP. You only have the graylisted requests from the top part of the matrix left. The ones you're most likely to change when trying to get a site to work... right? httpsbblacklistabpunchecked

my-password-is-password avatar May 16 '14 17:05 my-password-is-password