cordova-brother-label-printer icon indicating copy to clipboard operation
cordova-brother-label-printer copied to clipboard

Published 20 hours ago • verified publisher icon gordol

[AA] Making dev branch compile and passing paperLabelName parameter

Open arcadius opened this issue 6 years ago • 4 comments

  • Had to comment some of the iOS code to make the project compile on iOS
  • Added a new param paperLabelName ( that can be for instance W62 or or W62RB or ..... Note that I have tested only W62RB)
  • These changes work for both Android and iOS

While we are awaiting approval and merge from @gordobot , you can install the fixed version by doing:

cordova plugin add https://github.com/MenelicSoftware/cordova-plugin-brother-label-printer#dev --save

arcadius avatar Jun 24 '18 06:06 arcadius

Cool! If someone else can verify that this works, I'm happy to merge it now. Otherwise, I'm in the middle of moving, and won't be able to test this for at least a week or two. Apologies... Thanks so much for your hard work on this!

gordol avatar Jun 24 '18 06:06 gordol

What are the binary changes here? Updated android libraries?

gordol avatar Jun 24 '18 06:06 gordol

@Ayiga and @VictorCoding ... would you be able to verify that this install and works for both android and ios when the paperLabelName is passed in?

arcadius avatar Jun 24 '18 07:06 arcadius

What are the binary changes here? Updated android libraries?

Good catch @gordol :-)

The binary library upgrade was unintentional and has been reverted. The focus of this pull request is to get the iOS in dev working and have the label name passed down to the printer.

arcadius avatar Jun 24 '18 15:06 arcadius