react-svg-morph icon indicating copy to clipboard operation
react-svg-morph copied to clipboard

Published 20 hours ago • verified publisher icon gorangajic

Unsafe ComponentWill... lifecycle methods

Open dkemper01 opened this issue 4 years ago • 1 comments

Code at issue: https://github.com/gorangajic/react-svg-morph/blob/master/src/MorphReplace.js#L26, among others.

More on this:

  • https://reactjs.org/docs/react-component.html
  • https://hackernoon.com/problematic-react-lifecycle-methods-are-going-away-in-react-17-4216acc7d58b

Syntactically speaking, the methods as you have implemented them currently will no longer function as of React 17. You will at least need to use the UNSAFE variants, although I recommend not using them at all, or just using componentDidUpdate.

dkemper01 avatar May 26 '20 00:05 dkemper01

Thank you for reporting this. Currently, I don't use this lib in any active project. So, if you want to create that fix I will be more than happy to review your pull request and release that change.

gorangajic avatar May 26 '20 08:05 gorangajic