react-icon-base icon indicating copy to clipboard operation
react-icon-base copied to clipboard

Should the default style of `verticalAlign: middle` be removed from icons?

Open kumarharsh opened this issue 7 years ago • 2 comments

I wanted to suggest that the default verticalAlign be left to baseline, instead of being set to middle here:

Usecase

When using with text, it's almost always the case that the icon should align with the baseline instead of the text-middle. And when putting inside buttons as a standalone icon, the button's css would already take case of alignment.

Current Issues

Another issue with the putting default inline styles is that when using approaches different than CSS-in-JS, such as css-modules, I have to always write <IconEye style={{...}} />.

kumarharsh avatar Jan 11 '17 12:01 kumarharsh

+1

giiska avatar May 03 '17 04:05 giiska

Just started using react-icons and was wondering where the new inline style CSP warnings were coming from. I vote to remove the default inline style.

razor-x avatar Sep 26 '17 17:09 razor-x