gpr icon indicating copy to clipboard operation
gpr copied to clipboard

rggb12p pixel format issues

Open schoolpost opened this issue 5 years ago • 4 comments

Has this been verified working? if so what format does it expect for a RAW input file?

I've created a 12bit packed byte array and all my outputs have tons of artifacting due to what I imagine is incorrect demosaicing?

my camera's bayer sensor is BGGR so its flipped to match the expected input of RGGB.

It's 3280 x 2464 packed at 12bpp

I can verify my output is correct when I view the same byte array within a custom encoded dng sample.zip

schoolpost avatar Apr 06 '19 02:04 schoolpost

I have confirmed your findings, checking to find what is wrong.

dnewman-gpsw avatar Apr 07 '19 01:04 dnewman-gpsw

gpr_tools supports following formats: rggb12, rggb12p, [rggb14], gbrg12, gbrg12p. Your camera's format is bggr12p (where p is for packed), which is not supported at the moment.

You could do a flip offline and then feed flipped image to gpr_tools to see if that works.

adeelabbas avatar Apr 09 '19 23:04 adeelabbas

I'm looking into add the missing formats at the moment.

dnewman-gpsw avatar Apr 09 '19 23:04 dnewman-gpsw

gpr_tools supports following formats: rggb12, rggb12p, [rggb14], gbrg12, gbrg12p. Your camera's format is bggr12p (where p is for packed), which is not supported at the moment.

You could do a flip offline and then feed flipped image to gpr_tools to see if that works.

I'm actually already doing this flip, but even so there seems to be something wrong with the output when open in a RAW viewer.

schoolpost avatar Apr 10 '19 04:04 schoolpost