forgejs
forgejs copied to clipboard
gopro
Alps 904 - Video quality change
When requesting quickly a change in the quality of a video, the HTMLVideoElement wasn't always ready and thus null. We tried to remove some EventListener of something null, so it crashed. It is not the case anymore, as a check on the HTMLVideoElement (either null or undefined) is done.
Not related, but I can take a look at it and push it inside this PR. Note that there are also problems with the VideoControls plugin.
You're right @aberthet-gpsw I can reproduce the black screen issue on my mac/chrome with the master branch. I don't remember that happened on my Unbuntu desktop I will have to test again on Ubuntu to have a clear view of the bug. Have to test Firefox too !
@aberthet-gpsw Please if you want to have a look on this issue, come see me if you can't reproduce. :grin:
So I'm stopping here my changes, as I can't go further. The blocking element here is the loadstart event of the HTMLVideoElement which is fired not fast enough. If we change the quality of the video really quickly, before this event is fired, we get the bug we know, and I can't find a solution to fix that.
I propose to let it as it is, given that this bug shouldn't be reproduced by the vast majority of users. And as we plan to change in the future the inner workings of playable object (Video, Sound etc...), we may fix it at this moment.