feat(spx-gui): add custom formatter and parser to number inputs for handling special direction names
Closed #2428
Summary of Changes
Hello @Overu, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a significant improvement to user experience by enabling number input fields, specifically those controlling direction, to understand and display descriptive direction names alongside traditional numerical values. This is achieved by extending the core UINumberInput component with custom formatting and parsing capabilities, making the interface more intuitive and user-friendly for setting directions.
Highlights
- Enhanced Number Input: The
UINumberInputcomponent now supports customformatterandparserfunctions, allowing for flexible input and display of values beyond simple numbers. - Special Direction Names: Direction input fields (e.g.,
SpxDirectionInputandSpriteDirection) can now interpret and display special direction names (like 'up', 'down', 'left', 'right') in addition to numerical degree values. - New Utility Function: A new utility function,
valueForSpxDirection, has been added to convert string-based direction names into their corresponding numerical degree values.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
Code Review Summary
The implementation is clean and follows Vue 3 best practices. Three noteworthy issues identified:
🔴 Security: Parser functions should validate Number() output to prevent NaN/Infinity propagation (see inline comments)
🟡 Code Quality: Formatter/parser logic is duplicated across components - consider extracting to shared utilities
🟡 Documentation: Utility functions lack JSDoc explaining behavior and usage
Overall solid work! The performance characteristics are good, and the architecture integrates well with existing patterns.