1build icon indicating copy to clipboard operation
1build copied to clipboard

Published 20 hours ago • verified publisher icon gopinath-langote

Contributing.md doc issue

Open akhilbojedla opened this issue 5 years ago • 2 comments

Description

The repository doesn't seem to be using dep yet. It is still using go modules (vgo). However the doc asks to run dep init which fails.

Acceptance Criteria

Either the project should be migrated to use dep or update the doc to use vgo.

akhilbojedla avatar Sep 12 '19 20:09 akhilbojedla

Hello @akhilbojedla Thanks for creating an issue.

I have updated the contribution doc - in order to include go-modules info and remove go dep

As we have decided to use go-modules for this project.

gopinath-langote avatar Sep 13 '19 08:09 gopinath-langote

@gopinath-langote Thanks for updating. May be its work mentioning to add export GO111MODULE=on before go build

akhilbojedla avatar Sep 13 '19 23:09 akhilbojedla