gophercloud icon indicating copy to clipboard operation
gophercloud copied to clipboard

Identity v3: OS-EP-FILTERS endpoint groups list/get

Open nathancastelein opened this issue 3 years ago • 5 comments

For #1889

API doc: https://docs.openstack.org/api-ref/identity/v3-ext/index.html#os-ep-filter-api

API calls: https://github.com/openstack/keystone/blob/ba2e4b83e88d5c1576e9d2cd6a760367deef3a62/keystone/api/os_ep_filter.py#L68-L79

Structures: https://github.com/openstack/keystone/blob/ba2e4b83e88d5c1576e9d2cd6a760367deef3a62/keystone/catalog/backends/sql.py#L605

EndpointGroupFilter structure: https://github.com/openstack/keystone/blob/ba2e4b83e88d5c1576e9d2cd6a760367deef3a62/keystone/api/os_ep_filter.py#L54

Note: this is a new proposal based on this PR: https://github.com/gophercloud/gophercloud/pull/1893 I took care of the latests comments to move forward on this topic. If there are better ways to do it, feel free to share it and close this PR. Thanks !

nathancastelein avatar Jan 10 '22 11:01 nathancastelein

Coverage Status

coverage: 79.119% (-0.02%) from 79.14% when pulling cdc2866a4e0e1f71d1c225bc7cb6bdfbdd74e507 on garbage-collector:identity-endpointgroups-list into dd0d36f663b69361ed3b5db4bced9caad18c542c on gophercloud:master.

coveralls avatar Jan 10 '22 11:01 coveralls

Build succeeded.

theopenlab-ci[bot] avatar Jan 10 '22 13:01 theopenlab-ci[bot]

Build succeeded.

theopenlab-ci[bot] avatar Jan 10 '22 17:01 theopenlab-ci[bot]

LGTM, just curious about the decreased testing coverage reported by the bot. Can you explain it? Otherwise I think this is ready to go.

EmilienM avatar Feb 03 '22 20:02 EmilienM

Hi @garbage-collector,

Note: this is a new proposal based on this PR: https://github.com/gophercloud/gophercloud/pull/1893 I took care of the latests comments to move forward on this topic. If there are better ways to do it, feel free to share it and close this PR. Thanks !

Unfortunately github doesn't allow multiple people working on the same PR unless all contributors have write access to the repository. One way to do it would be to submit the PR from an organization fork, if you folks work for the same org. Another way would be to have @pgaxatte add you as a contributor to his repo. Have you tried contacting him? That's what I would do first, as he may still be interested to work on his PR. Otherwise, opening a new PR is fine I guess, however it would be good to add @pgaxatte as a co-author if you're not cherry-picking his commits directly to give him credit for the initial work. Simply add a line with Co-authored-by: name <[email protected]> at the end of the commit message.

mandre avatar May 21 '22 19:05 mandre

Hello,

I'd like to forfeit my changes to @garbage-collector. We actually work for the same team and he took over this work when I didn't need it anymore.

I will completely drop the PR on my side.

Do you need me to do more than that?

pgaxatte avatar Aug 25 '23 07:08 pgaxatte