Identity v3: OS-EP-FILTERS endpoint groups list/get
For #1889
API doc: https://docs.openstack.org/api-ref/identity/v3-ext/index.html#os-ep-filter-api
API calls: https://github.com/openstack/keystone/blob/ba2e4b83e88d5c1576e9d2cd6a760367deef3a62/keystone/api/os_ep_filter.py#L68-L79
Structures: https://github.com/openstack/keystone/blob/ba2e4b83e88d5c1576e9d2cd6a760367deef3a62/keystone/catalog/backends/sql.py#L605
EndpointGroupFilter structure: https://github.com/openstack/keystone/blob/ba2e4b83e88d5c1576e9d2cd6a760367deef3a62/keystone/api/os_ep_filter.py#L54
Note: this is a new proposal based on this PR: https://github.com/gophercloud/gophercloud/pull/1893 I took care of the latests comments to move forward on this topic. If there are better ways to do it, feel free to share it and close this PR. Thanks !
coverage: 79.119% (-0.02%) from 79.14% when pulling cdc2866a4e0e1f71d1c225bc7cb6bdfbdd74e507 on garbage-collector:identity-endpointgroups-list into dd0d36f663b69361ed3b5db4bced9caad18c542c on gophercloud:master.
Build succeeded.
- gophercloud-unittest : SUCCESS in 4m 10s
- gophercloud-acceptance-test-compute : SUCCESS in 2h 12m 45s
Build succeeded.
- gophercloud-unittest : SUCCESS in 5m 38s
- gophercloud-acceptance-test-compute : SUCCESS in 2h 10m 36s
LGTM, just curious about the decreased testing coverage reported by the bot. Can you explain it? Otherwise I think this is ready to go.
Hi @garbage-collector,
Note: this is a new proposal based on this PR: https://github.com/gophercloud/gophercloud/pull/1893 I took care of the latests comments to move forward on this topic. If there are better ways to do it, feel free to share it and close this PR. Thanks !
Unfortunately github doesn't allow multiple people working on the same PR unless all contributors have write access to the repository. One way to do it would be to submit the PR from an organization fork, if you folks work for the same org. Another way would be to have @pgaxatte add you as a contributor to his repo. Have you tried contacting him? That's what I would do first, as he may still be interested to work on his PR.
Otherwise, opening a new PR is fine I guess, however it would be good to add @pgaxatte as a co-author if you're not cherry-picking his commits directly to give him credit for the initial work. Simply add a line with Co-authored-by: name <[email protected]> at the end of the commit message.
Hello,
I'd like to forfeit my changes to @garbage-collector. We actually work for the same team and he took over this work when I didn't need it anymore.
I will completely drop the PR on my side.
Do you need me to do more than that?