gopass icon indicating copy to clipboard operation
gopass copied to clipboard

setup creates new branch in existing store

Open leogott opened this issue 5 months ago • 0 comments

Summary

When I installed gopass on a new system, I tried to follow proper procedure for once, and wanted to set it up with a new dedicated gpg key. The setup script unexpectedly created a new empty master branch in my pw-store repository, and pushed the public key there. This probably happened, because the OS-included version of git inits new repositories with a master-branch, and I hadn't yet configured git config --global init.defaultBranch main, (but I didn't verify whether the issue would occur, had I done that beforehand).

Managed to fix it, but some trial and error was involved.

I forgot to report this bug on the day… I hope my missive is accurate enough.

Steps To Reproduce

  1. have an existing pw-store git-repo with a single (default-)branch that is not named master or what your git init.defaultBranch is set to
  2. run gopass setup with this repo
  3. ???
  4. profit

Expected behavior

gopass setup should clone the existing branch (and/or ask which branch to use and whether to create a new empty branch)

Environment

  • OS: Pop!OS (based on ubuntu)
  • OS version: 22.04 LTS
  • gopass Version: v1.15.11, I think
  • Installation method: github release

Additional context

leogott avatar Mar 05 '24 14:03 leogott