gopass icon indicating copy to clipboard operation
gopass copied to clipboard

Move to Go Git

Open AnomalRoil opened this issue 4 years ago • 4 comments
trafficstars

Summary

It has been previously discussed in #1365 and other issues that we would prefer to not have dependencies on external binaries. Git is currently such a dependency.

We should probably move away from it by relying on https://github.com/go-git/go-git

AnomalRoil avatar Jan 12 '21 14:01 AnomalRoil

Warning: This is only possible once there is a green checkmark next to the word "merge" in https://github.com/go-git/go-git/blob/master/COMPATIBILITY.md#supported-capabilities

dominikschulz avatar Jan 12 '21 14:01 dominikschulz

Also we need to ensure that we'd keep supporting gitremote-helpers.

dominikschulz avatar Jan 12 '21 14:01 dominikschulz

That's effectively a big blocker then and I couldn't find an open issue about it.

https://github.com/src-d/go-git/issues/745 used to discuss it before go-git was moved to its new repo, but it seems it wasn't moved to the new repo yet (https://github.com/go-git/go-git/issues/9 is still open)

AnomalRoil avatar Jan 12 '21 14:01 AnomalRoil

Just checking, go-git still doesn't have merge support. Seems to be either tricky and or boring so nobody wants to fix it :(

dominikschulz avatar Dec 24 '21 06:12 dominikschulz

As long as go-git doesn't have merge support this is not an option. Closing this for the time being since there has been zero movement on that feature since I first looked at it.

dominikschulz avatar Dec 04 '22 14:12 dominikschulz