gopass icon indicating copy to clipboard operation
gopass copied to clipboard

Add tests for the GPG Onboarding Wizard

Open dominikschulz opened this issue 4 years ago • 5 comments
trafficstars

The Onboarding Wizard is largely untested.

We should add some automated tests to capture the primary user journeys here.

dominikschulz avatar Jan 12 '21 11:01 dominikschulz

hihi, can i check if this change is still required? i would like to contribute to this directory as part of this year's hacktoberfest

JoelLau avatar Oct 04 '24 13:10 JoelLau

@JoelLau this is still in need of better tests. But I have no idea how tricky this is since it's a lot of user interactions (terminal input). Feel free to a give it a try.

dominikschulz avatar Oct 05 '24 12:10 dominikschulz

@dominikschulz having a little trouble with my local setup. do you happen to have come across this error before?

$ go run . setup
# github.com/kbinani/screenshot
../../../../go/pkg/mod/github.com/kbinani/[email protected]/screenshot_darwin.go:10:9: error: 'CGDisplayCreateImageForRect' is unavailable: obsoleted in macOS 15.0 - Please use ScreenCaptureKit instead.
   10 |         return CGDisplayCreateImageForRect(display, rect);
      |                ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGDirectDisplay.h:391:33: note: 'CGDisplayCreateImageForRect' has been explicitly marked unavailable here
  391 | CG_EXTERN CGImageRef __nullable CGDisplayCreateImageForRect(
      |                                 ^
1 error generated.

JoelLau avatar Oct 18 '24 12:10 JoelLau

@JoelLau that looks like a deprecation notice from Apple. We can try updating the screenshot package. If that doesn't work we should report the issue upstream.

dominikschulz avatar Oct 18 '24 20:10 dominikschulz

I think it should work with the latest master, thanks https://github.com/kbinani/screenshot/pull/24 Sadly that project isn't tagging its releases.

AnomalRoil avatar Oct 19 '24 20:10 AnomalRoil