configurator icon indicating copy to clipboard operation
configurator copied to clipboard

Published 20 hours ago • verified publisher icon gopaddle-io

Website: Favicon not working

Open Adeesh-devanand opened this issue 3 years ago • 5 comments

Can anyone who has previously used jekyll, mmistakes theme please help fix the website favicon.

Here's the link to the config.yml file

Thank you for your help!!

Adeesh-devanand avatar Oct 06 '21 14:10 Adeesh-devanand

Please send pull requests to SODACODE-2022

gopaddle-io avatar Feb 28 '22 14:02 gopaddle-io

Can I fix this? I believe only favicon.ico is missing in the assets/images folder. <link rel="shortcut icon" type="image/x-icon" href="{{ site.baseurl }}/assets/images/favicon.ico"> https://github.com/gopaddle-io/configurator/blob/329f3c0ee731422be206a2a936de875226f6e67a/docs/_includes/head-custom.html I've generated a favicon using https://realfavicongenerator.ne which I can place in the above folder, and it should work I guess? The favicon generated looks like this - image

aimanfatima avatar Mar 13 '22 08:03 aimanfatima

Yes, you are right. We need a favicon as per the sample you had shared.

gopaddle-io avatar Mar 14 '22 14:03 gopaddle-io

Hey @aimanfatima, sure go ahead and send a pull request. I will test it on my environment before merging the code.

Adeesh-devanand avatar Mar 16 '22 08:03 Adeesh-devanand

@Adeesh-devanand created a PR https://github.com/gopaddle-io/configurator/pull/91 please review

aimanfatima avatar Mar 16 '22 14:03 aimanfatima