event icon indicating copy to clipboard operation
event copied to clipboard

feat: added support for custom relays

Open ajaysehwal opened this issue 2 weeks ago • 3 comments

Description

Relates to issue: ZEUS-3424

Please enter a description and screenshots, if appropriate, of the work covered in this PR

Simulator Screenshot - iPhone 17 Pro Max - 2025-12-12 at 13 51 39

This pull request is categorized as a:

  • [x] New feature
  • [ ] Bug fix
  • [x] Code refactor
  • [ ] Configuration change
  • [ ] Locales update
  • [ ] Quality assurance
  • [ ] Other

Checklist

  • [ ] I’ve run yarn run tsc and made sure my code compiles correctly
  • [ ] I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • [ ] I’ve run yarn run prettier and made sure my code is formatted correctly
  • [ ] I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • [ ] No, I’m a fool
  • [ ] Yes
  • [ ] N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • [ ] Android
  • [ ] iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • [ ] Embedded LND
  • [ ] LND (REST)
  • [ ] LND (Lightning Node Connect)
  • [ ] Core Lightning (CLNRest)
  • [ ] Nostr Wallet Connect
  • [ ] LndHub

Locales

  • [ ] I’ve added new locale text that requires translations
  • [ ] I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • [ ] Contributors will need to run yarn after this PR is merged in
  • [ ] 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • [ ] Changes were made that require an update to the README
  • [ ] Changes were made that require an update to onboarding

ajaysehwal avatar Dec 12 '25 08:12 ajaysehwal

Summary of Changes

Hello @ajaysehwal, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Nostr Wallet Connect (NWC) functionality by empowering users to configure and utilize custom Nostr relay servers. This core feature improves the flexibility and decentralization of NWC connections within the application. Complementing this, the PR also includes essential updates to iOS project dependencies and deployment targets, ensuring the application remains compatible and performs optimally on newer iOS versions.

Highlights

  • Custom Nostr Relays Support: Introduced the ability for users to specify and connect to custom Nostr relay URLs for Nostr Wallet Connect (NWC) connections, enhancing flexibility and decentralization.
  • NWC Connection Data Model Update: The NWCConnection data model now includes a customRelayUrl field to store user-defined relay addresses, ensuring persistence of custom configurations.
  • Enhanced User Interface for Relay Selection: The 'Add/Edit NWC Connection' screen has been updated with a new input field for custom relay URLs. This field dynamically appears when the 'custom' option is selected in the relay dropdown, providing an intuitive user experience.
  • Client-Side Relay URL Validation: Implemented client-side validation for custom Nostr relay URLs to ensure they adhere to a valid wss:// or ws:// format, preventing malformed entries.
  • iOS Project Dependency and Deployment Target Updates: Updated several iOS dependencies, including SwiftProtobuf, DoubleConversion, and glog. Additionally, the IPHONEOS_DEPLOYMENT_TARGET has been significantly increased to newer versions (15.6 and 26.0) across various build configurations, ensuring compatibility and leveraging modern platform features.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 12 '25 08:12 gemini-code-assist[bot]

use general.custom for the locale

kaloudis avatar Dec 12 '25 13:12 kaloudis

@gemini-code-assist review

ajaysehwal avatar Dec 12 '25 16:12 ajaysehwal

@gemini-code-assist review

ajaysehwal avatar Dec 13 '25 11:12 ajaysehwal

@gemini-code-assist review

ajaysehwal avatar Dec 13 '25 11:12 ajaysehwal

@gemini-code-assist review

ajaysehwal avatar Dec 13 '25 11:12 ajaysehwal