event
event copied to clipboard
refactor: replace instances of width: '95%' with flex: 1 on rows with carets
Description
Relates to issue: ZEUS-3360
This pull request is categorized as a:
- [ ] New feature
- [x] Bug fix
- [x] Code refactor
- [ ] Configuration change
- [ ] Locales update
- [ ] Quality assurance
- [ ] Other
Checklist
- [ ] I’ve run
yarn run tscand made sure my code compiles correctly - [ ] I’ve run
yarn run lintand made sure my code didn’t contain any problematic patterns - [ ] I’ve run
yarn run prettierand made sure my code is formatted correctly - [ ] I’ve run
yarn run testand made sure all of the tests pass
Testing
If you modified or added a utility file, did you add new unit tests?
- [ ] No, I’m a fool
- [ ] Yes
- [ ] N/A
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
- [ ] Android
- [ ] iOS
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
- [ ] Embedded LND
- [ ] LND (REST)
- [ ] LND (Lightning Node Connect)
- [ ] Core Lightning (CLNRest)
- [ ] Nostr Wallet Connect
- [ ] LndHub
Locales
- [ ] I’ve added new locale text that requires translations
- [ ] I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo
Third Party Dependencies and Packages
- [ ] Contributors will need to run
yarnafter this PR is merged in - [ ] 3rd party dependencies have been modified:
- verify that
package.jsonandyarn.lockhave been properly updated - verify that dependencies are installed for both iOS and Android platforms
- verify that
Other:
- [ ] Changes were made that require an update to the README
- [ ] Changes were made that require an update to onboarding
@ajaysehwal There are few more instances of
width : 95%, should we replace them as well ?
Only the PaymentSetting and UtxoPicker views are unchanged, because their layouts break significantly if we remove the width: 95% styling