event icon indicating copy to clipboard operation
event copied to clipboard

feat: reload invoice on restart

Open kwsantiago opened this issue 1 month ago • 7 comments

Description

Relates to issue: ZEUS-3361

Saves pending payment data to storage when enabling Express Graph Sync, then automatically restores and displays the invoice/payment after app restart. Handles both Lightning invoices and keysend payments.

This pull request is categorized as a:

  • [x] New feature
  • [ ] Bug fix
  • [ ] Code refactor
  • [ ] Configuration change
  • [ ] Locales update
  • [ ] Quality assurance
  • [ ] Other

Checklist

  • [x] I've run yarn run tsc and made sure my code compiles correctly
  • [x] I've run yarn run lint and made sure my code didn't contain any problematic patterns
  • [x] I've run yarn run prettier and made sure my code is formatted correctly
  • [x] I've run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • [ ] No, I'm a fool
  • [x] Yes
  • [ ] N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • [ ] Android
  • [ ] iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • [x] Embedded LND
  • [ ] LND (REST)
  • [ ] LND (Lightning Node Connect)
  • [ ] Core Lightning (CLNRest)
  • [ ] Nostr Wallet Connect
  • [ ] LndHub

Locales

  • [ ] I've added new locale text that requires translations
  • [x] I'm aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • [ ] Contributors will need to run yarn after this PR is merged in
  • [ ] 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • [ ] Changes were made that require an update to the README
  • [ ] Changes were made that require an update to onboarding

kwsantiago avatar Nov 18 '25 22:11 kwsantiago

@kwsantiago, could you please review the failing commit and push the first commit again? It looks like the second commit is unnecessary

ajaysehwal avatar Nov 19 '25 11:11 ajaysehwal

@ajaysehwal fixed in b4164983a7afdbe2f474ad8842126c1484bc9144

kwsantiago avatar Nov 19 '25 14:11 kwsantiago

@shubhamkmr04 resolved in 788c70b4ec90a54b7a3efc2da2275d1fa00a74b0

kwsantiago avatar Nov 25 '25 15:11 kwsantiago

@shubhamkmr04 resolved in 788c70b

some tests are failing.

shubhamkmr04 avatar Nov 25 '25 17:11 shubhamkmr04

@shubhamkmr04 the same tests are passing locally, could be a CI issue? Could you confirm on your end?

kwsantiago avatar Nov 25 '25 18:11 kwsantiago

If the testrunner fails, please disregard, as long as it is passing locally. There's a race condition in it we have to fix.

kaloudis avatar Nov 26 '25 16:11 kaloudis

@gemini-code-assist review

kaloudis avatar Dec 11 '25 16:12 kaloudis

@gemini-code-assist review

kaloudis avatar Dec 15 '25 20:12 kaloudis

I'm not seeing the Prettier fail locally, is this a CI issue?

kwsantiago avatar Dec 15 '25 21:12 kwsantiago