enhancement: add ability to set tax rate for individual items
Description
Relates to issue: ZEUS- #3053
Please enter a description and screenshots, if appropriate, of the work covered in this PR
Products with custom tax and Global tax
Products with only Global Tax
Products with flat prices
This pull request is categorized as a:
- [x] New feature
- [ ] Bug fix
- [x] Code refactor
- [ ] Configuration change
- [ ] Locales update
- [ ] Quality assurance
- [ ] Other
Checklist
- [x] I’ve run
yarn run tscand made sure my code compiles correctly - [x] I’ve run
yarn run lintand made sure my code didn’t contain any problematic patterns - [x] I’ve run
yarn run prettierand made sure my code is formatted correctly - [x] I’ve run
yarn run testand made sure all of the tests pass
Testing
If you modified or added a utility file, did you add new unit tests?
- [ ] No, I’m a fool
- [ ] Yes
- [x] N/A
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
- [ ] Android
- [x] iOS
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
- [ ] Embedded LND
- [ ] LND (REST)
- [ ] LND (Lightning Node Connect)
- [ ] Core Lightning (CLNRest)
- [ ] Nostr Wallet Connect
- [ ] LndHub
Locales
- [ ] I’ve added new locale text that requires translations
- [ ] I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo
Third Party Dependencies and Packages
- [ ] Contributors will need to run
yarnafter this PR is merged in - [ ] 3rd party dependencies have been modified:
- verify that
package.jsonandyarn.lockhave been properly updated - verify that dependencies are installed for both iOS and Android platforms
- verify that
Other:
- [ ] Changes were made that require an update to the README
- [ ] Changes were made that require an update to onboarding
If you have an order that only uses items that have the global tax, does it still display the % next to each item?
If you have an order that only uses items that have the global tax, does it still display the % next to each item?
Yeah, if you look at this screenshot, +20% is the global tax
If you have an order that only uses items that have the global tax, does it still display the % next to each item?
Yeah, if you look at this screenshot, +20% is the global tax
This screen shot has a mix of global and own tax items. What does it look like when you have an order with items that do not have their own tax (global tax only)?
If you have an order that only uses items that have the global tax, does it still display the % next to each item?
Yeah, if you look at this screenshot, +20% is the global tax
This screen shot has a mix of global and own tax items. What does it look like when you have an order with items that do not have their own tax (global tax only)?
so you mean if no one product has its own tax, then we show the global tax at once, not with all products
If you have an order that only uses items that have the global tax, does it still display the % next to each item?
Yeah, if you look at this screenshot, +20% is the global tax
This screen shot has a mix of global and own tax items. What does it look like when you have an order with items that do not have their own tax (global tax only)?
so you mean if no one product has its own tax, then we show the global tax at once, not with all products
Exactly.
Tax calculation here doesn't look right it should be 100 sats + (~863 sats) + 900 sats = 1863 sats ($1.95)
Still waiting on a screenshot of an order with only the global tax rate
only the global tax rate
Hi @kaloudis, could you please review this PR now ?
@ajaysehwal rebase, don't do merge commits
