feat : added ability to add a watchtower
Description
Relates to issue: ZEUS-0000 #2058 Please enter a description and screenshots, if appropriate, of the work covered in this PR
This pull request is categorized as a:
- [x] New feature
- [ ] Bug fix
- [ ] Code refactor
- [ ] Configuration change
- [ ] Locales update
- [ ] Quality assurance
- [ ] Other
Checklist
- [x] I’ve run
yarn run tscand made sure my code compiles correctly - [x] I’ve run
yarn run lintand made sure my code didn’t contain any problematic patterns - [x] I’ve run
yarn run prettierand made sure my code is formatted correctly - [x] I’ve run
yarn run testand made sure all of the tests pass
Testing
If you modified or added a utility file, did you add new unit tests?
- [ ] No, I’m a fool
- [ ] Yes
- [x] N/A
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
- [x] Android
- [x] iOS
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
- [ ] Embedded LND
- [ ] LND (REST)
- [ ] LND (Lightning Node Connect)
- [ ] Core Lightning (CLNRest)
- [ ] Nostr Wallet Connect
- [ ] LndHub
Locales
- [ ] I’ve added new locale text that requires translations
- [ ] I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo
Third Party Dependencies and Packages
- [ ] Contributors will need to run
yarnafter this PR is merged in - [ ] 3rd party dependencies have been modified:
- verify that
package.jsonandyarn.lockhave been properly updated - verify that dependencies are installed for both iOS and Android platforms
- verify that
Other:
- [ ] Changes were made that require an update to the README
- [ ] Changes were made that require an update to onboarding
Hi @kaloudis, can you please review this PR
Hi @kaloudis, can you please review this PR
There's nothing to review, you've just added endpoints without wiring the up for use
Hi @kaloudis, can you please review this PR
There's nothing to review, you've just added endpoints without wiring the up for use
Yes, I know. That's actually why I raised this PR as a draft. I will wire it up as well; I just wanted to confirm if I am going in the right direction.
Hi @shubhamkmr04, could you please review my PR now? Also, let me know if I missed wiring up Watchtower anywhere
Hi @kaloudis, I just want to know ,if I still forgot to wiring up watchtower somewhere , please let me know
Hi @kaloudis, I just want to know ,if I still forgot to wiring up watchtower somewhere , please let me know
It's fine. Please leave it marked as a draft until all the views are wired up.
Hi @kaloudis, I just want to know ,if I still forgot to wiring up watchtower somewhere , please let me know
It's fine. Please leave it marked as a draft until all the views are wired up.
sure
Let's not show searchbar when there are no watchtowers added
Let's also update the README to check the Watchtower support item off in the features list
@ajaysehwal we have some conflicts in the branch
let me fix all those commits