event icon indicating copy to clipboard operation
event copied to clipboard

feat : added ability to add a watchtower

Open ajaysehwal opened this issue 8 months ago • 7 comments

Description

Relates to issue: ZEUS-0000 #2058 Please enter a description and screenshots, if appropriate, of the work covered in this PR

This pull request is categorized as a:

  • [x] New feature
  • [ ] Bug fix
  • [ ] Code refactor
  • [ ] Configuration change
  • [ ] Locales update
  • [ ] Quality assurance
  • [ ] Other

Checklist

  • [x] I’ve run yarn run tsc and made sure my code compiles correctly
  • [x] I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • [x] I’ve run yarn run prettier and made sure my code is formatted correctly
  • [x] I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • [ ] No, I’m a fool
  • [ ] Yes
  • [x] N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • [x] Android
  • [x] iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • [ ] Embedded LND
  • [ ] LND (REST)
  • [ ] LND (Lightning Node Connect)
  • [ ] Core Lightning (CLNRest)
  • [ ] Nostr Wallet Connect
  • [ ] LndHub

Locales

  • [ ] I’ve added new locale text that requires translations
  • [ ] I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • [ ] Contributors will need to run yarn after this PR is merged in
  • [ ] 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • [ ] Changes were made that require an update to the README
  • [ ] Changes were made that require an update to onboarding

ajaysehwal avatar Apr 26 '25 13:04 ajaysehwal

Hi @kaloudis, can you please review this PR

ajaysehwal avatar Apr 26 '25 14:04 ajaysehwal

Hi @kaloudis, can you please review this PR

There's nothing to review, you've just added endpoints without wiring the up for use

kaloudis avatar Apr 27 '25 00:04 kaloudis

Hi @kaloudis, can you please review this PR

There's nothing to review, you've just added endpoints without wiring the up for use

Yes, I know. That's actually why I raised this PR as a draft. I will wire it up as well; I just wanted to confirm if I am going in the right direction.

ajaysehwal avatar Apr 27 '25 01:04 ajaysehwal

Hi @shubhamkmr04, could you please review my PR now? Also, let me know if I missed wiring up Watchtower anywhere

ajaysehwal avatar Apr 28 '25 04:04 ajaysehwal

Hi @kaloudis, I just want to know ,if I still forgot to wiring up watchtower somewhere , please let me know

ajaysehwal avatar May 01 '25 02:05 ajaysehwal

Hi @kaloudis, I just want to know ,if I still forgot to wiring up watchtower somewhere , please let me know

It's fine. Please leave it marked as a draft until all the views are wired up.

kaloudis avatar May 04 '25 23:05 kaloudis

Hi @kaloudis, I just want to know ,if I still forgot to wiring up watchtower somewhere , please let me know

It's fine. Please leave it marked as a draft until all the views are wired up.

sure

ajaysehwal avatar May 05 '25 02:05 ajaysehwal

Let's not show searchbar when there are no watchtowers added

shubhamkmr04 avatar Aug 15 '25 09:08 shubhamkmr04

Let's also update the README to check the Watchtower support item off in the features list

kaloudis avatar Aug 19 '25 11:08 kaloudis

@ajaysehwal we have some conflicts in the branch

shubhamkmr04 avatar Aug 19 '25 17:08 shubhamkmr04

let me fix all those commits

ajaysehwal avatar Aug 19 '25 17:08 ajaysehwal