event icon indicating copy to clipboard operation
event copied to clipboard

Update to React Native 0.74.1

Open myxmaster opened this issue 9 months ago • 3 comments

Description

Based on #2176, so should be merged after that.

Skipped changes for iOS-specific files, so that still needs to be done: https://react-native-community.github.io/upgrade-helper/?from=0.73.7&to=0.74.1

This pull request is categorized as a:

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Code refactor
  • [ ] Configuration change
  • [ ] Locales update
  • [ ] Quality assurance
  • [x] Other

Checklist

  • [ ] I’ve run yarn run tsc and made sure my code compiles correctly
  • [x] I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • [x] I’ve run yarn run prettier and made sure my code is formatted correctly
  • [x] I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • [ ] No, I’m a fool
  • [ ] Yes
  • [x] N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • [x] Android
  • [ ] iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • [x] Embedded LND
  • [x] LND (REST)
  • [ ] LND (Lightning Node Connect)
  • [ ] Core Lightning (c-lightning-REST)
  • [ ] LndHub
  • [ ] [DEPRECATED] Core Lightning (Spark)
  • [ ] [DEPRECATED] Eclair

Locales

  • [ ] I’ve added new locale text that requires translations
  • [ ] I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • [x] Contributors will need to run yarn after this PR is merged in
  • [x] 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • [ ] Changes were made that require an update to the README
  • [ ] Changes were made that require an update to onboarding

myxmaster avatar May 06 '24 20:05 myxmaster

@myxmaster can you rebase this one to remove 3bae746 so the changes are more grokable?

kaloudis avatar May 22 '24 02:05 kaloudis

Done.

myxmaster avatar May 22 '24 07:05 myxmaster

We are stuck on v0.73 for the foreseeable future due to react-native-vision-camera

https://github.com/mrousavy/react-native-vision-camera/issues/2798 https://github.com/mrousavy/react-native-vision-camera/issues/2614

kaloudis avatar May 22 '24 23:05 kaloudis

@kaloudis you can apply this patch to fix the build error with vision camera:

diff --git a/node_modules/react-native-vision-camera/android/src/main/java/com/mrousavy/camera/frameprocessors/VisionCameraProxy.kt b/node_modules/react-native-vision-camera/android/src/main/java/com/mrousavy/camera/frameprocessors/VisionCameraProxy.kt
index d697befe..8de418b0 100644
--- a/node_modules/react-native-vision-camera/android/src/main/java/com/mrousavy/camera/frameprocessors/VisionCameraProxy.kt
+++ b/node_modules/react-native-vision-camera/android/src/main/java/com/mrousavy/camera/frameprocessors/VisionCameraProxy.kt
@@ -7,12 +7,14 @@ import com.facebook.jni.HybridData
 import com.facebook.proguard.annotations.DoNotStrip
 import com.facebook.react.bridge.ReactApplicationContext
 import com.facebook.react.bridge.UiThreadUtil
+import com.facebook.react.common.annotations.FrameworkAPI
 import com.facebook.react.turbomodule.core.CallInvokerHolderImpl
 import com.facebook.react.uimanager.UIManagerHelper
 import com.mrousavy.camera.core.ViewNotFoundError
 import com.mrousavy.camera.react.CameraView
 import java.lang.ref.WeakReference
 
+@OptIn(FrameworkAPI::class)
 @Suppress("KotlinJniMissingFunction") // we use fbjni.
 class VisionCameraProxy(private val reactContext: ReactApplicationContext) {
   companion object {

losh11 avatar Jun 13 '24 03:06 losh11

Updated react-native-vision-camera to the current version which supports react-native 0.74. Also updated packages again and fixed string ref deprecation warnings.

myxmaster avatar Jun 13 '24 19:06 myxmaster

Podfile.lock updated for iOS

Now building successfully on both Android and iOS

kaloudis avatar Jun 13 '24 22:06 kaloudis