event
event copied to clipboard
Display amount on Receive screen above QR code
Description
This fixes #1600.
Before:
After:
This pull request is categorized as a:
- [x] New feature
- [ ] Bug fix
- [ ] Code refactor
- [ ] Configuration change
- [ ] Locales update
- [ ] Quality assurance
- [ ] Other
Checklist
- [x] I’ve run
yarn run tsc
and made sure my code compiles correctly - [x] I’ve run
yarn run lint
and made sure my code didn’t contain any problematic patterns - [x] I’ve run
yarn run prettier
and made sure my code is formatted correctly - [x] I’ve run
yarn run test
and made sure all of the tests pass
Testing
If you modified or added a utility file, did you add new unit tests?
- [ ] No, I’m a fool
- [ ] Yes
- [x] N/A
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
- [x] Android
- [ ] iOS
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
- [x] LND (REST)
- [ ] LND (Lightning Node Connect)
- [ ] Core Lightning (c-lightning-REST)
- [ ] Core Lightning (Spark)
- [ ] Eclair
- [ ] LndHub
Locales
- [ ] I’ve added new locale text that requires translations
- [ ] I’m aware that new translations should be made on the Zeus Transfix page and not directly to this repo
Third Party Dependencies and Packages
- [ ] Contributors will need to run
yarn
after this PR is merged in - [ ] 3rd party dependencies have been modified:
- verify that
package.json
andyarn.lock
have been properly updated - verify that dependencies are installed for both iOS and Android platforms
- verify that
Other:
- [ ] Changes were made that require an update to the README
- [ ] Changes were made that require an update to onboarding
Amount is now hidden if zero for on-chain. Added converted amount (same logic as in balanace pane):
Good idea. Done.
After talking to @kaloudis this feature should be opt-in.
So, ToDo: make it configurable in settings and disabled by default