event icon indicating copy to clipboard operation
event copied to clipboard

Remove android.enableJetifier line from gradle.properties & jetifier usage

Open emanuelb opened this issue 2 years ago • 4 comments

https://github.com/ZeusLN/zeus/blob/a2dcfd7f652b95a14af58bebd6493c77b3466e66/android/gradle.properties#L21 See this guide for the steps to ensure it's safe to remove above line android.enableJetifier=true (check that all deps are already fully migrated to AndroidX, and migrate the ones still not migrated to it) https://medium.com/dipien/say-bye-bye-to-android-jetifier-a7e0d388f5d6

Also remove line of jetifier package: https://github.com/ZeusLN/zeus/blob/ca19350c0071ec3d8f9a44cb832fe6cf1babcecd/package.json#L130

Compiling app result in "Jetifier is deprecated" warning.

Jetifier is deprecated. Future versions of react-native CLI may not run it by default.
Jetifier found 1553 file(s) to forward-jetify. Using 6 workers...
Jetifier: propose an AndroidX conversion PR to this repository: node_modules/react-native-tcp/android/src/main/java/com/peel/react/TcpSocketManager.java
Jetifier: propose an AndroidX conversion PR to this repository: node_modules/react-native-tcp/android/src/main/java/com/peel/react/TcpSockets.java
Jetifier: propose an AndroidX conversion PR to this repository: node_modules/react-native-udp/android/src/main/java/com/tradle/react/UdpSocketClient.java
Jetifier: propose an AndroidX conversion PR to this repository: node_modules/react-native-udp/android/src/main/java/com/tradle/react/UdpSockets.java

emanuelb avatar Aug 04 '22 00:08 emanuelb

@emanuelb are you open to making a PR to address this?

kaloudis avatar Aug 30 '22 22:08 kaloudis

I think #1634 should be merged first because currently, the support library is still present.

myxmaster avatar Sep 04 '23 19:09 myxmaster

@myxmaster we ready to rip this out now?

kaloudis avatar Apr 10 '24 04:04 kaloudis

Not yet. react-native-notifications still uses the support library and needs to be jetified. Sadly there is no update.

Jetifier is deprecated. Future versions of react-native CLI may not run it by default.
Jetifier found 1689 file(s) to forward-jetify. Using 24 workers...
Jetifier: propose an AndroidX conversion PR to this repository: node_modules\react-native-notifications\android\app\src\reactNative59\java\com\wix\reactnativenotifications\NotificationManagerCompatFacade.java
Jetifier: propose an AndroidX conversion PR to this repository: node_modules\react-native-notifications\android\app\src\reactNative59\java\com\wix\reactnativenotifications\NotificationManagerCompatFacade.java
Jetifier: propose an AndroidX conversion PR to this repository: node_modules\react-native-notifications\lib\android\app\src\reactNative59\java\com\wix\reactnativenotifications\NotificationManagerCompatFacade.java
Jetifier: propose an AndroidX conversion PR to this repository: node_modules\react-native-notifications\lib\android\app\src\reactNative59\java\com\wix\reactnativenotifications\NotificationManagerCompatFacade.java

myxmaster avatar Apr 12 '24 19:04 myxmaster