event icon indicating copy to clipboard operation
event copied to clipboard

Custom block explorer url force prefixed with https://

Open moonsettler opened this issue 2 years ago • 1 comments

Describe the bug

When setting a Custom Block explorer over VPN the http:// prefix is ignored. Resulting url looks like this: https://http//<ip_address>:/...

Recommendation: Should only prefix url with https if schema is not explicitly defined in the url!

Also potentially an issue with http:// tor .onion links (have not tried).

Reproduce

Using version v0.6.5, set custom block explorer url with schema!

Settings > Privacy settings > Default Block explorer: Custom Custom Block explorer: http://<any_host>:<any_port>

Press a tx-id, to open link in a bowser!

Zeus version

v0.6.4

Network

Clearnet

Device

Android

Device operating system

v11

Log output

No response

moonsettler avatar Jul 27 '22 12:07 moonsettler

Found an other problem, related to how the url is assembled based on type and host.

https://github.com/moonsettler/zeus/compare/master...issue_1051-patch-1

moonsettler avatar Jul 27 '22 23:07 moonsettler

This should be fixed in v0.6.6

kaloudis avatar Sep 26 '22 17:09 kaloudis

confirmed! (sorry i forgot to close)

moonsettler avatar Sep 26 '22 17:09 moonsettler