go-socket.io
go-socket.io copied to clipboard
googollee
Socket.io 2.0 support
Is there anything planned for it?
I can't get it to work with JS socket.io-client, the connection just never seems to happen.
No. I don't have time to maintain this project now. You can fork it and add the feature yourself.
No. At least I don't know. If any one want to take it, please notice me. I can write it in README.
On Wed, Nov 22, 2017 at 12:00 AM, Matthew [email protected] wrote:
@googollee https://github.com/googollee any official forks? any new maintainer?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/googollee/go-socket.io/issues/188#issuecomment-346189535, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeTjlGnPRpFKWtFf6v7FgrBd7dosMQ_ks5s41YngaJpZM4QlGn1 .
There is no active full development on this repo going on, but more contributors are very welcome to submit PR. I'm here to help get PR's merged and checked :)
Guys, any one working on it. We are using this library at prod, and getting many issues. Any plans to update or mark the project as archived and show link to actively maintained fork. Seriously dude. This is the only stable socket.io lib available and its broken AF..
@googollee can you share implementation details or any architecture diagram of this project?
This project needs help and we mention it in every issue. Please support it by making PR’s fixing issues. Assume no help from maintainers but feel free to ask targeted questions. If you benefit from the project: we need your help. Dont just complain. We’ll help you merge fixes ASAP.
@erkie I understand that, the problem is there is no documentation why there is v1.0 v1.4 and v1.4.1 and what are the purpose. which API is going to be supported? Latest master API is not compatible with v1.4.1. Can I get some light on it.
Why people are not directly contributing to this project, for example https://github.com/pschlump/socketio seems to fix some issues.
@kunaldawn as per the README, the master branch aims to be compatible with version 1.4 of Socket.io. With that in mind, can we count on your passion to help this project? :) Like I've mentioned, I'd be more than happy to assist getting PR's merged. Looking forward to seeing you in the PR section soon!
@erkie let me understand the code base first, we are still using v1.0 and sometimes OnClose panics. It seems v1.4.1 has the fix (using sync.Once) but missing Broadcast feature. Let me fix my production server first, crash is causing our stateful service to fail and make us panic :P, will surely contribute if I am able to understand this big project.
hi @erkie, as per my analysis v1.0 and v1.4 has some broken api changes. Our server code architecture is written in such a way its dependent on the following apis:
- Broadcast feature form server instance #230
- Adding On handlers to connection itself #231
For the broadcast API #230, I have raised a PR https://github.com/googollee/go-socket.io/pull/239
Now I am working on providing On api #231 in Conn interface, but the problem is for EVENT there could be only one writer, for example of I do server.OnEvent("ns", "event_1", func..) and conn.On("event_1", func..) only one of listeners ack can be written back. Currently i have decided that if direct On handlers are added they will get higher preference that global namespace handlers.
@erkie can you suggest some thing on what will be the proper way to bring On(event string, func...) #231 API back to Conn interface.
I found ambelovsky had finish socket.io 2.0 support . https://github.com/ambelovsky/gosf-socketio
